Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

feat(directive): ng:switch #1958

Closed
wants to merge 4 commits into from
Closed

Conversation

lgalfaso
Copy link
Contributor

@lgalfaso lgalfaso commented Feb 6, 2013

Added the ability to handle multiple matches on ng:switch-when and ng:switch-default

Closes #1074

Added the ability to handle multiple matches on ng:switch-when and ng:switch-default

Closes angular#1074
@pkozlowski-opensource
Copy link
Member

PR Checklist (Minor Feature)

  • Feature improves existing core functionality
  • API is compatible with existing Angular apis and relevant standards (if applicable)
  • Contributor signed CLA now or in the past (after signing leave a comment here with your real name)
  • PR doesn't contain a breaking change
  • PR contains unit tests
  • PR contains e2e tests (if suitable)
  • PR contains documentation update
  • PR was tested on ci.angularjs.org for cross-browser compatibility
  • PR is rebased against recent master
  • PR is squashed into one commit per logical change
  • All changes requested in review have been implemented
  • PR's commit message is descriptive and allows us to autogenerate release notes (required commit message format)

@IgorMinar
Copy link
Contributor

is the main motivation behind this PR ability to switch over groups of table rows or list items (where it's impossible to create artificial divs to group nodes)? If so, the unit tests should reflect that.

…ture

make the test explicit that this feature is needed when it is not possible
to add some artificial <div> element
update the documentation on supporting multiple matches for ng:switch
@lgalfaso
Copy link
Contributor Author

lgalfaso commented Feb 7, 2013

you are right, the motivation is that sometimes it is not possible to add artificial elements

@lgalfaso
Copy link
Contributor Author

Do not want to be a pain in the neck here, but would it be possible to know if there is anything else needed for this patch to be merged?

@ghost ghost assigned IgorMinar Feb 15, 2013
@IgorMinar
Copy link
Contributor

I made a few cosmetic changes and landed the change as 0af1720

thanks for the contribution!

@IgorMinar IgorMinar closed this Feb 15, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ng-switch should allow non ng-when children
3 participants