Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

fix(sce) IE 7 standards mode not supported #3646

Closed
wants to merge 3 commits into from

Conversation

justinrknowles
Copy link
Contributor

Changed documentMode test from 8 to 7 to support IE 8 in IE 7 standards mode while still protecting against quirks mode. documentMode returns the following values: 5 - quirks mode, 7 - IE 7 standards mode, 8 - IE 8 standards mode. Closes #3633.

Changed to 7 to support IE 8 in IE 7 standards mode while still protecting against quirks mode.  documentMode returns the following values: 5 - quirks mode, 7 - IE 7 standards mode, 8 - IE 8 standards mode.
'documentMode' is being used to test for quirks mode.   This property was introduced in IE 8  and returns one of the following values: 5 - quirks mode, 7 - IE 7 standards mode, 8 - IE 8 standards mode.  Test should return 5 not 7 for quirks mode.
Added tests for IE8 in IE7 standards mode.
@IgorMinar
Copy link
Contributor

cc: @chirayuk - just fyi

@ghost ghost assigned IgorMinar Aug 21, 2013
@IgorMinar IgorMinar closed this in 637c9b1 Aug 21, 2013
@chirayuk
Copy link
Contributor

I just saw this now.

IE8 supports CSS expressions in both quirks and IE7 compatibility mode.  It's only in IE8 standards mode that IE8 disallows CSS expressions.

If IE7 must be supported, it should probably be via an explicit configuration setting than by default as done in this commit.

@chirayuk chirayuk reopened this Aug 22, 2013
@justinrknowles
Copy link
Contributor Author

I think one could argue that a user is supplying an explicit configuration with IE8 in IE7 standards mode as supply nothing results in quirks mode (5) where as 7 is only returned when the app supplies the following meta tag <meta http-equiv="X-UA-Compatible" content="IE=7">. That being said, I think it's great that the option can be disabled when configuring your module so I can solve my issue without modifying angular core without #3633 being merged.

chirayuk added a commit to chirayuk/angular.js that referenced this pull request Aug 23, 2013
This reverts commit 637c9b1.
(ref angular#3633 and angular#3646)

The minimum bar for $sce is IE8 in standards mode.  IE7 standards mode
is not supported.  If you must support IE7, you should disable $sce
completely.

  angular.module('ie7support', []).config(function($sceProvider) {
    // Completely disable SCE to support IE7.
    $sceProvider.enabled(false);
  });
chirayuk added a commit that referenced this pull request Aug 23, 2013
This reverts commit 637c9b1.
(ref #3633 and #3646)

The minimum bar for $sce is IE8 in standards mode.  IE7 standards mode
is not supported.  If you must support IE7, you should disable $sce
completely.

  angular.module('ie7support', []).config(function($sceProvider) {
    // Completely disable SCE to support IE7.
    $sceProvider.enabled(false);
  });
@chirayuk
Copy link
Contributor

@justinrknowles

I wanted IE8 standards mode at the minimum for $sce.  (IE7 standards mode isn't good enough.)  I've reverted 637c9b1

To disable $sce completely in order to support IE7, you can use code like this:

angular.module('ie7support', []).config(function($sceProvider) {
  // Completely disable SCE to support IE7.
  $sceProvider.enabled(false);
});

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular doesn’t work in IE 7 with v1.2.0rc1 at all
3 participants