This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix(compiler): revert 8611ebe6 - calling after linking #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change introduced by me in 8611ebe results in considerable inefficiencies when the compiler and linker is used from within a widget, in which case, we call $digest unnecessary since it will be called by the $apply which called the directive/widget in the first place. There are only two places when the extra $digest call can be useful - when manually bootstrapping the app or in tests. However even in tests this behavior can result in unwanted results (especially when ng:controller is involved). So it is better to leave it for the developer to call $digest when it is really needed.
|
[angular.js] IgorMinar force-pushed master from 77bf5e0 to f38010d: http://git.io/eb2NaA |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change introduced by me in 8611ebe results in considerable inefficiencies when the compiler
and linker is used from within a widget, in which case, we call $digest unnecessary since it
will be called by the $apply which called the directive/widget in the first place.
There are only two places when the extra $digest call can be useful - when manually bootstrapping
the app or in tests. However even in tests this behavior can result in unwanted results (especially
when ng:controller is involved). So it is better to leave it for the developer to call $digest
when it is really needed.