This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(tabs): remove manual pagination sizing algorithm #10136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clshortfuse
added
browser: Chrome
needs: manual testing
googlebot
added
cla: yes
|
@ErinCoughlan this should solve your issue Just to clarify, this changes the width of the Tested with: http://codepen.io/shortfuse/pen/LbXVWP (localhost)
|
clshortfuse
force-pushed
the
tabsFixDynamicWidth
branch
from
f1772df
to
0b02727
Compare
Since tabs now use flexbox for sizing, manually sizing is no longer needed. This solves issues related tabs inside flexible containers like dialogs. * Remove updatePagingWidth() function * Revert width to default values Fixes angular#9429
clshortfuse
force-pushed
the
tabsFixDynamicWidth
branch
from
0b02727
to
4abec2e
Compare
clshortfuse
added
ui: flexbox
g3: reported
clshortfuse
changed the title
ErinCoughlan
approved these changes
Dec 20, 2016
|
@clshortfuse - nice work. |
davidenochk
pushed a commit
to davidenochk/material
that referenced
this pull request
Feb 3, 2017
Since tabs now use flexbox for sizing, manually sizing is no longer needed. This solves issues related tabs inside flexible containers like dialogs. * Remove updatePagingWidth() function * Revert width to default values Fixes angular#9429
|
@clshortfuse @ErinCoughlan please see #10386 |
|
This appears to have broken the display of tabs when pagination is needed on IE11: #10406 (comment) |
Splaktar
reviewed
Aug 30, 2018
| if (shouldStretchTabs()) { | ||
| angular.element(elements.paging).css('width', ''); | ||
| } else { | ||
| angular.element(elements.paging).css('width', calcPagingWidth() + 'px'); |
There was a problem hiding this comment.
This was the only call to calcPagingWidth() but that function wasn't removed as is currently dead code.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since tabs now use flexbox for sizing, manually sizing is no longer needed.
This solves issues related tabs inside flexible containers like dialogs.
Fixes #9429