Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix(layout): some flex directives don't work when on a child of layout="column" or layout="row" #11247

Merged
merged 2 commits into from
Apr 21, 2018

Conversation

Splaktar
Copy link
Member

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Some flex directives don't work when on a child of layout="column" or layout="row". This includes flex="0", flex="33", flex="66", flex="100".

Issue Number:
Fixes #9546

What is the new behavior?

flex="0", flex="33", flex="66", flex="100" now behave properly when applied to an element that is a child of an element with layout="column" or layout="row".

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Relates to and includes contents of PR #10797.

clshortfuse and others added 2 commits April 19, 2018 17:30
The current implementation's CSS rules did not properly override
other rules when using @media sizes.

* Add SCSS rules for flex-0 to flex-100
* Add SCSS rules for flex-33 and flex-66

Fixes #9546
@Splaktar Splaktar added this to the 1.1.9 milestone Apr 19, 2018
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added the cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ label Apr 19, 2018
@Splaktar Splaktar removed the cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ label Apr 19, 2018
@Splaktar
Copy link
Member Author

I reviewed the primary changes to the SCSS in #10797 and they LGTM. This PR just adds some whitespace cleanup and clarification to some comments.

@Splaktar Splaktar added pr: merge ready This PR is ready for a caretaker to review pr: lgtm This PR has been approved by the reviewer labels Apr 19, 2018
@mmalerba mmalerba merged commit e0078d7 into master Apr 21, 2018
@Splaktar Splaktar deleted the layout-media-row-columns branch April 21, 2018 18:03
Splaktar added a commit that referenced this pull request Jun 18, 2018
reduces unminified layout CSS size by ~77KB

Fixes #11000. Relates to #9546.
jelbourn pushed a commit that referenced this pull request Jun 19, 2018
reduces unminified layout CSS size by ~77KB

Fixes #11000. Relates to #9546.
chmelevskij pushed a commit to chmelevskij/material that referenced this pull request Jun 19, 2018
…t="column" or layout="row" (angular#11247)

* fix(layout): add missing media query overrides

The current implementation's CSS rules did not properly override
other rules when using @media sizes.

* Add SCSS rules for flex-0 to flex-100
* Add SCSS rules for flex-33 and flex-66

Fixes angular#9546

* style(layout): clean up whitespace and comments
Splaktar added a commit that referenced this pull request Jul 31, 2018
…t="column" or layout="row" (#11247)

* fix(layout): add missing media query overrides

The current implementation's CSS rules did not properly override
other rules when using @media sizes.

* Add SCSS rules for flex-0 to flex-100
* Add SCSS rules for flex-33 and flex-66

Fixes #9546

* style(layout): clean up whitespace and comments
Splaktar added a commit that referenced this pull request Jul 31, 2018
reduces unminified layout CSS size by ~77KB

Fixes #11000. Relates to #9546.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P2: required Issues that must be fixed. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review type: bug ui: flexbox ui: layout
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flex-md and other flex-* media query directives not overriding properly
4 participants