Skip to content

Commit

Permalink
browser version capability should be a string when parsing command li…
Browse files Browse the repository at this point in the history
…ne options for a node.

fixes SeleniumHQ#3204
  • Loading branch information
lukeis committed Dec 5, 2016
1 parent bd3f14c commit 465ef4d
Showing 1 changed file with 6 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import com.beust.jcommander.IStringConverter;

import org.openqa.selenium.Platform;
import org.openqa.selenium.remote.CapabilityType;
import org.openqa.selenium.remote.DesiredCapabilities;

public class BrowserDesiredCapabilityConverter implements IStringConverter<DesiredCapabilities> {
Expand All @@ -30,6 +31,11 @@ public DesiredCapabilities convert(String value) {
String[] pieces = cap.split("=");
String capabilityName = pieces[0].trim();
String capabilityValue = pieces[1].trim();
if (capabilityName.equals(CapabilityType.VERSION)) {
// store version as a string, DesiredCapabilities assumes version is a string
capabilities.setCapability(capabilityName, capabilityValue);
continue;
}
try {
final Long x = Long.parseLong(capabilityValue);
capabilities.setCapability(capabilityName, x);
Expand Down

0 comments on commit 465ef4d

Please sign in to comment.