Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed mentorship relation API response to return name of users #123

Merged
merged 1 commit into from
Aug 6, 2018
Merged

Fixed mentorship relation API response to return name of users #123

merged 1 commit into from
Aug 6, 2018

Conversation

isabelcosta
Copy link
Member

@isabelcosta isabelcosta commented Aug 6, 2018 •
edited
Loading

Description

This PR fixes the response from Mentorship Relation APIs, returning the name of the User.

Fixes #121

Type of Change:

  • Code

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Fixed tests related to Mentorship Relation APIs

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Update Swagger documentation and the exported file at /docs folder

Code/Quality Assurance Only

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@isabelcosta
Copy link
Member Author

Don't know I Codacy did not run here?!

@isabelcosta
Copy link
Member Author

@m-murad @roopalJazz this is ready to be reviewed. cc @Dilu9218

@isabelcosta
Copy link
Member Author

Ok Codacy woke up :D

@r00pal r00pal merged commit bfc870a into anitab-org:gsoc18-code Aug 6, 2018
@isabelcosta isabelcosta added the Program: GSOC Related to work completed during the Google Summer of Code Program. label Aug 9, 2018
@isabelcosta isabelcosta deleted the restructure-relations-api-response branch December 30, 2018 01:51
b-thebest pushed a commit to b-thebest/mentorship-backend that referenced this pull request Mar 2, 2021
@isabelcosta
fix: mentorship relation apis return name of users (anitab-org#123)
6e183e5
RiddhiAthreya pushed a commit to RiddhiAthreya/mentorship-backend that referenced this pull request Jul 1, 2021
@isabelcosta @RiddhiAthreya
fix: mentorship relation apis return name of users (anitab-org#123)
40bcb20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-murad m-murad m-murad approved these changes

@r00pal r00pal r00pal approved these changes

Assignees
No one assigned
Labels
Program: GSOC Related to work completed during the Google Summer of Code Program.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@isabelcosta @m-murad @r00pal @sys-bot