-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set explicit timezone for cron jobs #147
Conversation
@ivernus thank you for submitting this PR.
|
@ivernus before sending a PR, make sure that you claim the issue. |
@ivernus if you have any trouble squashing commits here's a quick tutorial by GitHub on that -> https://help.github.com/articles/changing-a-commit-message/ |
@ivernus I think you squashed one commit of another contributor by mistake :/ you have changes from another issue, previously committed, in here. Is that right? |
Yep I'm afraid so @isabelcosta . Is that fixed now? |
@ivernus I'm sorry for the delay! I was a bit busy this week. I'm so happy you got to solve it!! 🎉 Can you just change the commit message to follow the Commit Message Style Guide. Here's a suggestion: To do this you can just amend the message of the commit and push force to update the remote repository. If you don't know how to do this, you can do the following:
and then:
After this change, I can approve and merge right away :D Also for next times please create a specific branch for the issue you're working on. |
It seems to do that amend it detached the head and I joined it back in, but that has messed up the single commit 🤦♂️ |
@ivernus 🤦♀️ git can be so frustrating sometimes!! The thing is that you had the right commit there in between. Can you look into undoing those commits, something like |
Hopefully that does the trick @isabelcosta 😪 |
@ivernus thank you for your patience! that does the trick! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ivernus Thank you for your contribution and following our contribution guidelines 🎉
Description
Found issue #81 and saw that it had been open quite some time. I hope this is what you were looking for.
Minor fix for #81, setting timezone in cron job to UTC
Fixes #81
Type of Change:
Code/Quality Assurance Only
Checklist: