Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set explicit timezone for cron jobs #147

Merged
merged 1 commit into from
Nov 1, 2018
Merged

Set explicit timezone for cron jobs #147

merged 1 commit into from
Nov 1, 2018

Conversation

Conor0Callaghan
Copy link
Contributor

@Conor0Callaghan Conor0Callaghan commented Oct 14, 2018

Description

Found issue #81 and saw that it had been open quite some time. I hope this is what you were looking for.
Minor fix for #81, setting timezone in cron job to UTC

Fixes #81

Type of Change:

  • Code

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials

@isabelcosta isabelcosta added the Type: Enhancement New feature or request. label Oct 16, 2018
@isabelcosta
Copy link
Member

@ivernus thank you for submitting this PR.
Can you please do the following:

  • Follow our Commit Message Style Guidelines for your commit (squashed commit)
  • Squash the 2 commits into one, following this ^^ guideline
  • Update the name of the PR, to be more descriptive (e.g.: Set explicit timezone to cron job)

@m-murad
Copy link
Contributor

m-murad commented Oct 16, 2018

@ivernus before sending a PR, make sure that you claim the issue.

@Conor0Callaghan Conor0Callaghan changed the title Minor fix for #81 Set explicit timezone for cron jobs Oct 16, 2018
@isabelcosta
Copy link
Member

@ivernus if you have any trouble squashing commits here's a quick tutorial by GitHub on that -> https://help.github.com/articles/changing-a-commit-message/

@isabelcosta
Copy link
Member

@ivernus I think you squashed one commit of another contributor by mistake :/ you have changes from another issue, previously committed, in here. Is that right?

@Conor0Callaghan
Copy link
Contributor Author

Conor0Callaghan commented Oct 27, 2018

Yep I'm afraid so @isabelcosta . Is that fixed now?

@isabelcosta
Copy link
Member

isabelcosta commented Nov 1, 2018

@ivernus I'm sorry for the delay! I was a bit busy this week. I'm so happy you got to solve it!! 🎉

Can you just change the commit message to follow the Commit Message Style Guide. Here's a suggestion: feat: set timezone in cron job to UTC

To do this you can just amend the message of the commit and push force to update the remote repository.

If you don't know how to do this, you can do the following:

git commit --amend -m "feat: set timezone in cron job to UTC"

and then:

git push -f origin develop

After this change, I can approve and merge right away :D

Also for next times please create a specific branch for the issue you're working on.

@Conor0Callaghan
Copy link
Contributor Author

If you don't know how to do this, you can do the following:

git commit --amend -m "feat: set timezone in cron job to UTC"

and then:

git push -f origin develop

It seems to do that amend it detached the head and I joined it back in, but that has messed up the single commit 🤦‍♂️

@isabelcosta
Copy link
Member

@ivernus 🤦‍♀️ git can be so frustrating sometimes!! The thing is that you had the right commit there in between. Can you look into undoing those commits, something like git reset --soft (..........) I'm not sure it depends on the situation. Can you take a look at that? I messed up git commits and heads a few times in the past as well 🤦‍♀️

@Conor0Callaghan
Copy link
Contributor Author

Hopefully that does the trick @isabelcosta 😪

@isabelcosta
Copy link
Member

@ivernus thank you for your patience! that does the trick!

Copy link
Member

@isabelcosta isabelcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ivernus Thank you for your contribution and following our contribution guidelines 🎉

@isabelcosta isabelcosta merged commit f46ece7 into anitab-org:develop Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set a timezone from the deployed server on the corn jobs
3 participants