Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add local as an option for FLASK_ENVIRONMENT_CONFIG variable in env.template file #666

Merged
merged 1 commit into from
Jul 14, 2020

Conversation

PrashanthPuneriya
Copy link
Contributor

Description

Adds local value as an option for FLASK_ENVIRONMENT_CONFIG variable.

Fixes #663

Type of Change:

  • Documentation

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials

@vj-codes vj-codes added Category: Documentation/Training Improvements or additions to documentation. Status: Needs Review PR needs an additional review or a maintainer's review. labels Jul 14, 2020
Copy link
Member

@vj-codes vj-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on sending your first PR to backend repo!!! @PrashanthPuneriya

@vj-codes
Copy link
Member

@PrashanthPuneriya Just remember about creating a new branch again while working on other issues

@PrashanthPuneriya
Copy link
Contributor Author

@vj-codes Thanks! I will remember it.

Copy link
Member

@isabelcosta isabelcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @PrashanthPuneriya 👏 👏 👏
Thank you for this contribution 🎉

@isabelcosta isabelcosta merged commit 4098de5 into anitab-org:develop Jul 14, 2020
@isabelcosta
Copy link
Member

@anitab-org/qa-team this PR was not tested because it is a documentation task

b-thebest pushed a commit to b-thebest/mentorship-backend that referenced this pull request Mar 2, 2021
RiddhiAthreya pushed a commit to RiddhiAthreya/mentorship-backend that referenced this pull request Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Documentation/Training Improvements or additions to documentation. Status: Needs Review PR needs an additional review or a maintainer's review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a missing environment config value to .env.template
3 participants