make gossip encryption optional fixes #126 #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwmrocker
commented
Nov 22, 2017
| register: consul_keygen | ||
|
|
||
| - name: Write key locally to share with other nodes | ||
| - block: |
There was a problem hiding this comment.
i just indented the whole part and wrapped a block around it
brianshumate
suggested changes
Nov 22, 2017
defaults/main.yml
Outdated
| @@ -142,6 +142,9 @@ consul_acl_master_token_display: "{{ lookup('env','CONSUL_ACL_MASTER_TOKEN_DISPL | |||
| consul_acl_replication_enable: "{{ lookup('env','CONSUL_ACL_REPLICATION_ENABLE') | default('',true) }}" | |||
| consul_acl_replication_token: "{{ lookup('env','CONSUL_ACL_REPLICATION_TOKEN') | default('', true) }}" | |||
|
|
|||
| ## gossip encryption | |||
| consul_encrypt_enable: "{{ lookup('env','CONSUL_TLS_ENABLE') | default(true, true) }}" | |||
There was a problem hiding this comment.
Perhaps this Ansible variable can also have its own environment variable, like CONSUL_ENCRYPT_ENABLE for example instead of using CONSUL_TLS_ENABLE?
|
Oh, 🙈 sure I will fix this.
…On Wed, 22 Nov 2017, 19:36 Brian Shumate, ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In defaults/main.yml
<#127 (comment)>
:
> @@ -142,6 +142,9 @@ consul_acl_master_token_display: "{{ lookup('env','CONSUL_ACL_MASTER_TOKEN_DISPL
consul_acl_replication_enable: "{{ lookup('env','CONSUL_ACL_REPLICATION_ENABLE') | default('',true) }}"
consul_acl_replication_token: "{{ lookup('env','CONSUL_ACL_REPLICATION_TOKEN') | default('', true) }}"
+## gossip encryption
+consul_encrypt_enable: "{{ lookup('env','CONSUL_TLS_ENABLE') | default(true, true) }}"
Perhaps this Ansible variable can also have its own environment variable,
like CONSUL_ENCRYPT_ENABLE for example instead of using CONSUL_TLS_ENABLE?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#127 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAENANB_JgX8rjZLDrGleGbWkembJ92Bks5s5GmTgaJpZM4QntqK>
.
|
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a new variable
consul_encrypt_enable.The default value will not change anything, but if you set it to false it will skip all parts that are handling gossip encryption stuff.