Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add consul health check scripts, working on RHEL 7 #183

Closed
wants to merge 3 commits into from
Closed

add consul health check scripts, working on RHEL 7 #183

wants to merge 3 commits into from

Conversation

TheLastChosenOne
Copy link

but should work on other Linux Distributions too
add support for OracleLinux which is basically a RedHat/CentOS

Copy link
Member

@bbaassssiiee bbaassssiiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase to resolve the conflicts in your branch.

@TheLastChosenOne
Copy link
Author

Hope it's ok now - created this branch over a year ago.

Copy link
Contributor

@lanefu lanefu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think health checks configuration is appropriate for this role. That's an implementation detail that should be up to the end-user in another playbook or role.

@lanefu
Copy link
Contributor

lanefu commented Apr 3, 2020

@TheLastChosenOne

Your efforts are very much appreciated. Unfortunately this change is a bad fit for the role. (see #183 (review)).

@lanefu lanefu closed this Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants