Allow "Connect" for any and all nodes #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'consul_connect_enabled' is now the root of truth for allowing Consul connect functionality. This remediates the current functionality where Connect is only allowed on Consul SERVER nodes. Addresses ansible-collections#400
|
You can now use the |
|
@perlboy - I see that one of the check failed, but it's only because resources couldn't be created in a timely matter - is there a way I can rerun the tests |
|
@lanefu - do you know how I can rerun the molecule test case? |
|
@adawalli I re-ran the tests.. not sure if you're able to re-run... you'd see a re-run button from the detailed test view if so |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'consul_connect_enabled' is now the root of truth for allowing
Consul connect functionality. This remediates the current functionality
where Connect is only allowed on Consul SERVER nodes.
Addresses #400