Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix support for rhel8/centos8 #424

Merged
merged 1 commit into from
Jun 21, 2021

Conversation

felixb
Copy link
Contributor

@felixb felixb commented Dec 18, 2020

No description provided.

@felixb
Copy link
Contributor Author

felixb commented Dec 18, 2020

I've addressed the build/lint errors in #425. I'm happy to rebase this one when #425 is merged.

@bbaassssiiee
Copy link
Member

#425 was a duplicate, #418 was merged instead. So please rebase this PR if you are still interested in contributing.

@felixb
Copy link
Contributor Author

felixb commented Jun 21, 2021

@bbaassssiiee I just rebased my changes to the upstream/mater.

@bbaassssiiee
Copy link
Member

TODO: centos-6 can be removed.

@bbaassssiiee bbaassssiiee merged commit 4f73cb8 into ansible-collections:master Jun 21, 2021
@felixb felixb deleted the RHEL-8 branch June 21, 2021 07:26
@gardar
Copy link
Contributor

gardar commented Jan 4, 2022

@felixb & @bbaassssiiee
I'm not sure this change was necessary since /vars/RedHat.yml already includes differentconsul_os_packages for centos8, centos7, etc.

https://github.com/ansible-community/ansible-consul/blob/819f31dbe9cf35d566c7788416b57c468d5a2528/vars/RedHat.yml#L4-L14

Wouldn't it be cleaner to either add rhel to that list rather than specifying a whole new vars file for RedHat 8 or splitting them all up to vars files (Fedora.yml, OracleLinux.yml, etc ?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants