install: only install OS packages if non-empty due to Flatcar / CoreOS #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ahjohannessen
commented
Mar 1, 2022
•
ahjohannessen
commented
- only install OS packages if non-empty due to Flatcar / CoreOS not using a package manager.
|
@gardar Your change in #452 causes OSs that have no regular package manager, e.g. Flatcar and Fedora CoreOS, to fail installing. If you look at OS specific vars for Flatcar you can see this: My change here ensures that |
|
@bbaassssiiee WDYT? |
ahjohannessen
force-pushed
the
wip-fix-photon-os-change
branch
from
d17d661
to
1379418
Compare
|
@gardar Any chance of getting this merged soon? :) |
|
@ahjohannessen unfortunately I don't have write access to the repo so I can't merge. Pinging @lanefu |
bbaassssiiee
approved these changes
Apr 19, 2022
|
Could you remove the Fedora 29? Molecule fails on it. |
ahjohannessen
force-pushed
the
wip-fix-photon-os-change
branch
from
1379418
to
821cfb0
Compare
|
@bbaassssiiee I have removed fedora 29 |
ahjohannessen
force-pushed
the
wip-fix-photon-os-change
branch
from
821cfb0
to
2d6d873
Compare
|
@bbaassssiiee I reverted the removal of Fedora 29 as it probably was a Molecule glitch and unrelated to this PR. Tests are green with Fedora 29. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.