Fix undefined variable for repo installs

[sandipb]

#460 introduced an typo causing repo installations to fail

TASK [ansible-consul : Install OS packages] ***********************************************************************************************************************
fatal: [neptune]: FAILED! => {"msg": "The conditional check '(consul_os_repo_prerequisites)' failed. The error was: error while evaluating conditional ((consul_os_repo_prerequisites)): 'consul_os_repo_prerequisites' is undefined\n\nThe error appears to be in '***/.cache/roles/ansible-consul/tasks/install_linux_repo.yml': line 4, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Install OS packages\n  ^ here\n"}

Also reported here: #466

[nre-ableton]

Suggested change

	when: item.when
	when: "{{ dnsmasq_item.when }}"

See #488.

[sandipb]

@nre-ableton
The lint error was about jinja expressions being used in when. It only expected pure python expressions. Have you tried this out by lint?

[nre-ableton]

@sandipb True, but there are several other places in this role where such expressions are used, which is why my PR disabled the expression for the time being. I think that changing the other usages and re-enabling the warning deserves a separate PR.

However, my suggestion is not so much about the Jinja2 expressions but rather the use of item, which will be undefined and fail. That was named to dnsmasq_item here.

If you prefer, you could also do:

Suggested change

	when: item.when
	when: dnsmasq_item.when

[bbaassssiiee]

Duplicate