Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests with Ansible 2.9 as well #296

Merged
merged 4 commits into from
Jul 2, 2020
Merged

Run tests with Ansible 2.9 as well #296

merged 4 commits into from
Jul 2, 2020

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

As topic says.

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
COMPONENT NAME

CI

@ansibullbot
Copy link
Collaborator

cc @gundalow
click here for bot help

@ansibullbot ansibullbot added WIP bug This issue/PR relates to a bug tests tests labels May 6, 2020
@ansibullbot
Copy link
Collaborator

cc @Mogztter @MorrisA @bcoca @bendoh @d-little @flynn1973 @gforster @kairoaraujo @marvin-sinister @mator @molekuul @ramooncamacho @tumbl3w33d @turb @wtcross
click here for bot help

@felixfontein felixfontein force-pushed the ansible-2.9-tests branch 2 times, most recently from 1f4ec6f to 6a28a27 Compare May 8, 2020 05:39
@felixfontein felixfontein mentioned this pull request May 8, 2020
Merged
@ansibullbot ansibullbot removed the module module label May 8, 2020
@felixfontein felixfontein mentioned this pull request May 9, 2020
Merged
@felixfontein
Copy link
Collaborator Author

Tests are green! \o/ That means: if a new version of community.general gets published, and several 2.9 backports for Ansible merged, community.general is fully functional (at least from perspective of existing tests!) with Ansible 2.9.

@settings settings bot removed WIP labels Jun 16, 2020
@ansibullbot ansibullbot added WIP Work in progress needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci CI is older than 7 days, rerun before merging labels Jun 16, 2020
@ansibullbot ansibullbot removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci CI is older than 7 days, rerun before merging labels Jun 29, 2020
@felixfontein felixfontein changed the title [WIP] Try tests with stable-2.9 instead of devel Run tests with Ansible 2.9 as well Jul 2, 2020
@ansibullbot ansibullbot added community_review and removed WIP Work in progress labels Jul 2, 2020
@felixfontein
Copy link
Collaborator Author

In yesterday's meeting we decided to keep the symlinks at least for 1.x.y, and thus support Ansible 2.9. This PR adds CI testing with the latest Ansible 2.9 release. @gundalow said that RH is willing to pay for the additional CI costs (see meeting log). This PR implements them.

@felixfontein
Copy link
Collaborator Author

(The cancelled test is unrelated to this PR, it will be fixed in #598.)

@Andersson007
Copy link
Contributor

@felixfontein i'm not sure i understand the changes correctly but if a pr to main branch touches feaures that are not in 2.9, what will happen?

@felixfontein
Copy link
Collaborator Author

@Andersson007 I guess it needs to add some logic to the tests to skip the tests for 2.9. Right now I know of only one such feature, and there's a simple work-around for it which also makes it work with 2.9.

But that's the same problem we will have with 2.10 vs. devel vs. 2.11 (when it's around) etc.

Andersson007
Andersson007 approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@Andersson007 Andersson007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, tests with 2.9 make sense, at least, because it's supported.
i'm sure we'll cope with all consequences, LGTM :)

@Andersson007
Copy link
Contributor

and a number of red lines is larger than green which also looks good:) thanks for doing this

@felixfontein felixfontein merged commit 786f082 into ansible-collections:master Jul 2, 2020
@felixfontein felixfontein deleted the ansible-2.9-tests branch July 2, 2020 11:40
@felixfontein
Copy link
Collaborator Author

@Andersson007 thanks a lot for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andersson007 Andersson007 Andersson007 approved these changes

@gundalow gundalow Awaiting requested review from gundalow

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug community_review tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@felixfontein @ansibullbot @Andersson007