Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Remove action_groups_redirection entry from meta/runtime.yml #127

Merged
merged 1 commit into from
Jun 13, 2020
Merged

Remove action_groups_redirection entry from meta/runtime.yml #127

merged 1 commit into from
Jun 13, 2020

Conversation

s-hertel
Copy link
Contributor

@s-hertel s-hertel commented Jun 10, 2020

SUMMARY

The action_groups_redirection field which was originally intended to be included in 2.10 but is going to be reconsidered for the following release instead.

@geerlingguy I noticed you added a new 'helm' group to this collection. New group names are not being supported in 2.10 after all - only the whitelisted group names in 2.9 will work to keep backwards compatibility for the time being. Do you want me to remove the helm group and the modules listed under it since it's unusued?

ISSUE TYPE
  • Bugfix Pull Request

@codecov
Copy link

codecov bot commented Jun 10, 2020

Codecov Report

Merging #127 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #127   +/-   ##
=======================================
  Coverage   43.19%   43.19%           
=======================================
  Files           3        3           
  Lines         544      544           
  Branches      110      110           
=======================================
  Hits          235      235           
  Misses        266      266           
  Partials       43       43           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdeab63...e3f138a. Read the comment docs.

@geerlingguy
Copy link
Collaborator

@s-hertel - In terms of the helm group—this would still be used for people being able to set module_defaults in a group, right? In that case even if it's unused for redirection/routing, it would be useful to keep in the file.

@s-hertel
Copy link
Contributor Author

@geerlingguy People won't be able to use group/helm in playbooks like group/k8s yet. For 2.10, collections have support to modify their particular groups that existed in ansible/ansible already, and hopefully new groups will be supported in the following release.

@geerlingguy
Copy link
Collaborator

@s-hertel - No, but for the benefit of people who install the collection separately (in 2.9 or 2.10), or if they explicitly use group/community.k8s.helm, wouldn't that work?

@s-hertel
Copy link
Contributor Author

@geerlingguy group/community.k8s.helm won't be supported until the release after 2.10. But I could see why you might want to keep this, if you want an old version of the collection to work with an Ansible 2.11 playbook containing group/community.k8s.helm. The thing that has been done for 2.10 is to keep the existing groups working and to allow the owners of the content to add new content to those groups. I don't see a harm in keeping the helm entry though, besides possible confusion.

@geerlingguy
Copy link
Collaborator

Not having this fix started causing sanity test failures so merging it now :)

@geerlingguy geerlingguy merged commit 6588706 into ansible-collections:master Jun 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants