This repository has been archived by the owner on Jun 13, 2024. It is now read-only.
k8s_exec: Return rc for the command executed #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #158 +/- ##
=======================================
Coverage 42.41% 42.41%
=======================================
Files 3 3
Lines 547 547
Branches 111 111
=======================================
Hits 232 232
Misses 271 271
Partials 44 44 Continue to review full report at Codecov.
|
|
@geerlingguy @fabianvf @tima This is changing the behavior of the module. The module used to return True always. With this change, depending on the command return code it will report changed. Do you think we should add a toggle for enabling this feature? |
fabianvf
reviewed
Jul 10, 2020
k8s_exec now returns command return code in output. Fixes: ansible-collections#122 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
k8s_exec now returns command return code in output.
Fixes: #122
Signed-off-by: Abhijeet Kasurde akasurde@redhat.com
ISSUE TYPE
COMPONENT NAME
changelogs/fragments/122_k8s_exec_rc.yml
molecule/default/tasks/exec.yml
plugins/modules/k8s_exec.py