-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for ansible-builder #377
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cidrblock
requested review from
ssbarnea and
shatakshiiii
and removed request for
a team
September 18, 2024 21:17
cidrblock
changed the title
DNM Add test for ansible-builder
Add test for ansible-builder
Sep 19, 2024
alisonlhart
approved these changes
Sep 19, 2024
shatakshiiii
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note the failure in this test run:
opening file /sys/fs/cgroup/cgroup.subtree_control for writing: Read-only file system
https://github.com/ansible/ansible-dev-tools/actions/runs/10930266208/job/30342982168?pr=377
This is why
unmask=/sys/fs/cgroup
is added after the initial addition of the EE test which works for podman.For docker based on: moby/moby#42275 (comment)
--privileged
was added (not ideal, but few options)On macOS/intel/podman desktop the following errors were found:
Error: crun: mknod /dev/null: Operation not permitted: OCI permission denied
the following was added to resolve this error:
--cap-add=mknod
(docker gets this by default)this allowed all tests to pass on macOS/intel/podman desktop
Additional changes necessary for Windows user include the addition of
"--cap-add=NET_ADMIN",
to avoid
bpf query: Operation failed
errors when building an EE