Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VMware: Cleanup vCloud references #56268

Merged
merged 1 commit into from
May 9, 2019
Merged

VMware: Cleanup vCloud references #56268

merged 1 commit into from
May 9, 2019

Conversation

Akasurde
Copy link
Member

@Akasurde Akasurde commented May 9, 2019

SUMMARY

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/cloud/vmware/vmware_category.py
lib/ansible/modules/cloud/vmware/vmware_category_facts.py
lib/ansible/modules/cloud/vmware/vmware_tag.py
lib/ansible/modules/cloud/vmware/vmware_tag_facts.py
lib/ansible/modules/cloud/vmware/vmware_tag_manager.py
lib/ansible/plugins/inventory/vmware_vm_inventory.py
test/integration/targets/vmware_tag/aliases
test/integration/targets/vmware_tag/tasks/main.yml
test/integration/targets/vmware_tag/tasks/tag_crud_ops.yml
test/integration/targets/vmware_tag/tasks/tag_manager_ops.yml

@Akasurde
VMware: Cleanup vCloud references
b2745a1 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@Akasurde Akasurde requested review from goneri and jillr May 9, 2019 13:44
@Akasurde
Copy link
Member Author

Akasurde commented May 9, 2019

cc @pgbidkar Please review this.

@ansibot
Copy link
Contributor

ansibot commented May 9, 2019

cc @GBrawl @Tomorrow9 @dav1x @goneri @lparkes @warthog9
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. inventory Inventory category module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community labels May 9, 2019
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label May 9, 2019
@jillr jillr merged commit 499355f into ansible:devel May 9, 2019
@Akasurde Akasurde deleted the vcloud_clean branch May 10, 2019 05:18
@pgbidkar
Copy link
Contributor

cc @pgbidkar Please review this.

Thanks @Akasurde , PR is merged. I will review next PR :)

ndclt pushed a commit to ndclt/ansible that referenced this pull request Jun 13, 2019
@Akasurde @ndclt
VMware: Cleanup vCloud references (ansible#56268)
c0225e2 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
agowa pushed a commit to agowa/ansible-1 that referenced this pull request Jun 30, 2019
@Akasurde @agowa
VMware: Cleanup vCloud references (ansible#56268)
24c977e 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@goneri goneri goneri approved these changes

@jillr jillr jillr approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. inventory Inventory category module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Akasurde @ansibot @pgbidkar @goneri @jillr