Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VMware: Improve vmware_portgroup #56382

Merged
merged 2 commits into from
May 14, 2019
Merged

VMware: Improve vmware_portgroup #56382

merged 2 commits into from
May 14, 2019

Conversation

Akasurde
Copy link
Member

SUMMARY

Based upon work done by ckotte in #47052

  • Updated test cases
  • Updated logic
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/cloud/vmware/vmware_portgroup.py
test/integration/targets/vmware_portgroup/aliases
test/integration/targets/vmware_portgroup/tasks/main.yml

@ckotte @Akasurde
Rewrite vmware_portgroup module
d43d1e1 
* support check mode
* VLAN ID isn't required anymore
* VLAN ID 0 (no tagging) is the default
* Options match values in vSphere Client and vmware_vsitch module
* Policy override is configured properly
@Akasurde Akasurde mentioned this pull request May 14, 2019
Closed
@ansibot
Copy link
Contributor

ansibot commented May 14, 2019

cc @Tomorrow9 @dav1x @goneri @lparkes @warthog9
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community labels May 14, 2019
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels May 14, 2019
@Akasurde
VMware: vmware_portgroup updates
01cfb30 
* Updated logic
* Updated tests

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels May 14, 2019
@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label May 14, 2019
@Akasurde Akasurde merged commit 7a32bd8 into ansible:devel May 14, 2019
@Akasurde Akasurde deleted the vmware_portgroup branch May 14, 2019 09:04
This was referenced May 14, 2019
Closed
Closed
Closed
Closed
ndclt pushed a commit to ndclt/ansible that referenced this pull request Jun 13, 2019
@Akasurde @ndclt
VMware: Improve vmware_portgroup (ansible#56382)
01b2f11 
* Rewrite vmware_portgroup module
* support check mode
* VLAN ID isn't required anymore
* VLAN ID 0 (no tagging) is the default
* Options match values in vSphere Client and vmware_vswitch module
* Policy override is configured properly
* VMware: vmware_portgroup updates
@angystardust angystardust mentioned this pull request Aug 1, 2019
Closed
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Akasurde @ansibot @ckotte