Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

certificate_complete_chain: remove no longer necessary check #59953

Merged
merged 1 commit into from
Aug 9, 2019
Merged

certificate_complete_chain: remove no longer necessary check #59953

merged 1 commit into from
Aug 9, 2019

Conversation

felixfontein
Copy link
Contributor

SUMMARY

This should have been removed in the past, when support for validating list elements was added to module_utils/basic.py.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

certificate_complete_chain

@ansibot

This comment has been minimized.

Sign in to view
@ansibot
Copy link
Contributor

ansibot commented Aug 1, 2019

cc @MarkusTeufelberger @Shaps @Spredzy @Xyon @mattclay @puiterwijk @resmo
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. ci_verified Changes made in this PR are causing tests to fail. crypto Crypto community (ACME, openssl, letsencrypt) module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. small_patch support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Aug 1, 2019
@felixfontein felixfontein force-pushed the certificate_complete_chain-ignore branch from 321c6ac to cba1c8d Compare August 2, 2019 09:25
@ansibot
Copy link
Contributor

ansibot commented Aug 2, 2019

cc @MarkusTeufelberger @Shaps @Spredzy @Xyon @mattclay @puiterwijk @resmo
click here for bot help

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 2, 2019
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Aug 6, 2019
resmo
resmo approved these changes Aug 9, 2019
View reviewed changes
Copy link
Contributor

@resmo resmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipt

@resmo resmo merged commit 49e1692 into ansible:devel Aug 9, 2019
@felixfontein felixfontein deleted the certificate_complete_chain-ignore branch August 9, 2019 21:54
@ansible ansible locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@resmo resmo resmo approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. crypto Crypto community (ACME, openssl, letsencrypt) module This issue/PR relates to a module. small_patch support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@felixfontein @ansibot @resmo @samdoran