Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid HTTP request when Conjur credential secret has a space in the name #7191

Closed
AndrewCopeland opened this issue May 29, 2020 · 8 comments

Comments

@AndrewCopeland
Copy link
Contributor

ISSUE TYPE
  • Bug Report
SUMMARY

Invalid HTTP request when Conjur credential secret has a space in the name

STEPS TO REPRODUCE

Create a conjur credential containing a space.
When retrieving the credential a 404 is returned from conjur.
The reason for this is because the conjur credential plugin url encodes the secretID with a + however conjur is expecting a %20.

EXPECTED RESULTS

To get back the credential content.

ACTUAL RESULTS

AWX fails to retrieve the credential and a 404 is returned.

ADDITIONAL INFORMATION
@ryanpetrello
Copy link
Contributor

Hey @AndrewCopeland,

Mind giving this PR at try?

#7200

@Tovli
Copy link

Tovli commented Jun 4, 2020

Hi,
Can you say when will this fix be released? what version could we see it in?

@ryanpetrello
Copy link
Contributor

ryanpetrello commented Jun 8, 2020

@Tovli,

#7214

@Tovli
Copy link

Tovli commented Jun 8, 2020

Thanks. So we should see it in version 12.
That's great.
Any date/month that you plan to release this version in?

@ryanpetrello
Copy link
Contributor

ryanpetrello commented Jun 8, 2020

Hey @Tovli,

Probably somewhere in the coming weeks. I'd say "likely by the end of June".

@Tovli
Copy link

Tovli commented Jun 16, 2020

@ryanpetrello
I actually see a release of 12.0.0 but this issue is open
Wasn't it part of 12.0.0 after all?

@ryanpetrello
Copy link
Contributor

ryanpetrello commented Jun 16, 2020

Hey @Tovli,

The changes in question should be in the 12.0.0 release. We keep issues open until we've done actual per-issue verification on our end (that's what the state:needs_test label on this issue represents).

@one-t one-t self-assigned this Jul 7, 2020
@one-t
Copy link
Contributor

one-t commented Jul 8, 2020

Tested - this is now working as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants