Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't filter out schedules that have a null next_run #4378

Merged
merged 1 commit into from
Jul 25, 2019
Merged

don't filter out schedules that have a null next_run #4378

merged 1 commit into from
Jul 25, 2019

Conversation

ryanpetrello
Copy link
Contributor

@ryanpetrello ryanpetrello commented Jul 25, 2019 •
edited
Loading

when schedules are disabled, their next_run is unset (related: 40f9d0b); we should still
show them in this list view, just with an empty value in the next_run
column (they're disabled, so they'll never run)

@ryanpetrello
don't filter out schedules that have a null next_run
e711d32 
when schedules are disabled, their `next_run` is unset; we should still
show them in this list view, just with an empty value in the `next_run`
column (they're disabled, so they'll never run)
@ryanpetrello
Copy link
Contributor Author

ryanpetrello commented Jul 25, 2019 •
edited
Loading

Before this PR:
Kapture 2019-07-25 at 17 14 42

After this PR:
Kapture 2019-07-25 at 17 11 27

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 94e14ae into ansible:devel Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakemcdermott jakemcdermott jakemcdermott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanpetrello @jakemcdermott