Fixed "DEFAULT ANSWER" to be properly deleted for Integer and Float types #4479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded.
|
saito-hideki
changed the title
jakemcdermott
approved these changes
Aug 14, 2019
jakemcdermott
suggested changes
Aug 14, 2019
| data.default = scope.default_float; | ||
| } else if (scope.type.type === 'integer') { | ||
| } else if (scope.type.type === 'integer' && scope.default_int) { |
There was a problem hiding this comment.
@saito-hideki
We can't rely on the truthiness of scope.default_int for all cases. For example, this would prevent someone from updating the default value to 0.
There was a problem hiding this comment.
@saito-hideki
When these fields are cleared, their values can become an empty string or null depending on how it's been initialized.
Adding some more specificity to the validation checks might be all that's needed here:
...
} else if (scope.type.type === 'float' &&
scope.default_float !== '' &&
scope.default_float !== null) {
data.default = scope.default_float;
} else if (scope.type.type === 'integer' &&
scope.default_int !== '' &&
scope.default_int !== null) {
data.default = scope.default_int;
} else {
...There was a problem hiding this comment.
@jakemcdermott Thank you for your kind review!
As you pointed out, there was a problem with this condition handling. So I have fixed it.
jakemcdermott
suggested changes
Aug 14, 2019
There was a problem hiding this comment.
Just a minor revision is needed (see review comments) and I think this will be ready to go.
thanks for taking a look at this, @saito-hideki !
saito-hideki
changed the title
|
Build failed.
|
|
recheck |
|
Build failed.
|
|
Build succeeded.
|
|
@jakemcdermott Thank you for your great advice! I have fixed wrong condition handling. |
saito-hideki
changed the title
jakemcdermott
approved these changes
Aug 15, 2019
…ypes - Fixed issue ansible/tower#3639 Signed-off-by: Hideki Saito <saito@fgrep.org>
|
Build succeeded.
|
|
Build succeeded (gate pipeline).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixed the value of "DEFAULT ANSWER" to be properly deleted for Integer and Float types.
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION
None