fix broken project update secret filtering for external logging #5812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanpetrello
commented
Feb 3, 2020
| @@ -360,11 +360,10 @@ def _update_from_event_data(self): | |||
| value = force_text(event_data.get(field, '')).strip() | |||
| if value != getattr(self, field): | |||
| setattr(self, field, value) | |||
| if isinstance(self, JobEvent): | |||
There was a problem hiding this comment.
@chrismeyersfsu @AlanCoding I totally broke external event logging for project updates while refactoring recently 🤦♂
ryanpetrello
commented
Feb 3, 2020
| # with regex, but project updates don't have many events, | ||
| # so it *should* have a negligible performance impact | ||
| try: | ||
| event_data_json = json.dumps(event_data) |
There was a problem hiding this comment.
Historically, we've filtered this data only on the API side, but I think we should consider doing it here, too, because right now we ship this raw data to external loggers (where it may be unredacted).
chrismeyersfsu
approved these changes
Feb 3, 2020
|
Build succeeded.
|
|
Build succeeded (gate pipeline).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.