follow symlinks while discovering valid playbooks #6773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanpetrello
commented
Apr 21, 2020
| @@ -64,6 +64,7 @@ def could_be_playbook(project_path, dir_path, filename): | |||
| matched = True | |||
| break | |||
| except IOError: | |||
| logger.exception(f'failed to open {playbook_path}') | |||
There was a problem hiding this comment.
Can you test this with a directory loop instead of a file loop?
|
Build succeeded.
|
AlanCoding
approved these changes
Apr 21, 2020
related: ansible#6769 Co-authored-by: Francois Herbert <francois@herbert.org.nz>
ryanpetrello
force-pushed
the
playbook-scan-symlinks
branch
from
d58bb2d
to
3dd21d7
Compare
|
Build failed.
|
|
regate |
|
recheck |
|
Build succeeded.
|
|
Build succeeded (gate pipeline).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #6769
Co-authored-by: Francois Herbert francois@herbert.org.nz