Rework dev & prod container builds #7017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failed.
|
|
Well, that's one way to break zuul. |
AlanCoding
reviewed
May 14, 2020
|
recheck |
|
Build failed.
|
Use only one (templated) docker file for both builds. Move to two-stage container builds in order to save space in the final image.
|
Build failed.
|
|
recheck |
|
Build failed.
|
|
Build failed.
|
|
recheck |
|
Build succeeded.
|
|
recheck |
|
Build succeeded.
|
|
recheck |
|
Build succeeded.
|
|
recheck |
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
shanemcd
approved these changes
May 15, 2020
| @@ -35,6 +35,7 @@ rsyslog.pid | |||
| /tower-license | |||
| /tower-license/** | |||
| tools/prometheus/data | |||
| tools/docker-compose/Dockerfile | |||
ryanpetrello
approved these changes
May 15, 2020
|
Build failed (gate pipeline). For information on how to proceed, see
|
|
regate |
rooftopcellist
approved these changes
May 15, 2020
|
Build succeeded (gate pipeline).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Two main items:
The easiest way to make sure changes to the container builds don't get out of sync between the dev environment and prod containers is to only have one (templated) Dockerfile. So do that.
Move to two-stage container builds in order to save space in the final image.
By building in one container step, and then just copying the built artifacts into the final containers, we can save a lot of space.
Before:
After:
Changes while here:
Smoke tested with starting AWX & running demo playbook on Fedora 32 for both dev env and local docker prod. Definitely needs testing on OSX (dev env) and OCP/K8S (prod).