Sync the is_superuser flag when the members relationship changes #8833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ior it was only corroborating from the DB to RBAC and we need both ways
… impact the data sent within the POST so that it can impact the User model, this may not work because the POST is related only to the Roles model
|
Build failed.
|
AlanCoding
commented
Dec 10, 2020
| 'When the is_superuser flag is false but a user has the System Admin role, update the database to reflect that' | ||
| if kwargs['action'] in ['post_add', 'post_remove', 'post_clear']: | ||
| new_status_value = bool(kwargs['action'] == 'post_add') | ||
| if hasattr(instance, 'singleton_name'): # duck typing, role.members.add() vs user.roles.add() |
There was a problem hiding this comment.
If someone hates me too bad for this, you could use the reverse kwarg, but how do you know at a glance which is the reverse and which is the non-reverse?
There was a problem hiding this comment.
I was going to say something about the use of singleton_name here, but apparently that's an actual field on the Role model.
|
Build succeeded.
|
jbradberry
approved these changes
Dec 11, 2020
|
Build succeeded (gate pipeline).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was giving the wrong behavior before.
work started by @rebeccahhh at
devel...rebeccahhh:devel