Skip to content

Commit

Permalink
ClusterLoader: Log step's errors
Browse files Browse the repository at this point in the history
Our load config recently exceeded 500 lines. If you modify a few places
in the config and you get an error is super hard to find it in the yaml as errors are
only logged after the whole test, without information where it occurred. This logging will let user
know if there were any errors for a given step, which in most cases is
enough to easily locate the error it in the yaml file.
  • Loading branch information
mm4tt committed Sep 16, 2019
1 parent 4c0b3af commit 2385e39
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions clusterloader2/pkg/test/simple_test_executor.go
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,9 @@ func (ste *simpleTestExecutor) ExecuteStep(ctx Context, step *api.Step) *errors.
if step.Name != "" {
klog.Infof("Step %q ended", step.Name)
}
if !errList.IsEmpty() {
klog.Warningf("Got errors during step execution: %v", errList)
}
return errList
}

Expand Down

0 comments on commit 2385e39

Please sign in to comment.