Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ng15 with eslint #551

Merged
merged 3 commits into from
Nov 29, 2022
Merged

ng15 with eslint #551

merged 3 commits into from
Nov 29, 2022

Conversation

jornare
Copy link
Contributor

@jornare jornare commented Nov 27, 2022

Updated to Angular 15
Replaced deprecated tslint with new eslint
Removed unused protractor
Updated test script (type error)

@wzhudev
Copy link
Collaborator

wzhudev commented Nov 28, 2022

Thanks for your PR!

@jornare
Copy link
Contributor Author

jornare commented Nov 28, 2022

I see the react native tests are failing, but I did not and I'm not going to touch those parts.

@jornare
Copy link
Contributor Author

jornare commented Nov 28, 2022

I see that my PR is requesting to be merged directly to master. I'm not sure if that's appropriate. Please verify and change if needed.

Copy link
Collaborator

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev
Copy link
Collaborator

wzhudev commented Nov 29, 2022

I see the react native tests are failing, but I did not and I'm not going to touch those parts.

Please leave that to us. :p

Thanks for your pull request again. Much appreciated. The version and target branch are ok. We will make a release soon.

@wzhudev wzhudev merged commit 947c72e into ant-design:master Nov 29, 2022
@jornare jornare deleted the feat-angular-v15 branch December 8, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants