Fix/button icon loading not working #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zombieJ
reviewed
Jan 19, 2023
packages/icons-react/src/utils.ts
Outdated
| const { csp } = useContext(IconContext); | ||
| const { csp, prefixCls = 'anticon' } = useContext(IconContext); | ||
|
|
||
| if (typeof prefixCls === "string") { |
zombieJ
reviewed
Jan 19, 2023
packages/icons-react/src/utils.ts
Outdated
| @@ -142,7 +142,11 @@ export const iconStyles = ` | |||
| `; | |||
|
|
|||
| export const useInsertStyles = (styleStr: string = iconStyles) => { | |||
| const { csp } = useContext(IconContext); | |||
| const { csp, prefixCls = 'anticon' } = useContext(IconContext); | |||
There was a problem hiding this comment.
这里之前写的时候删掉了，后来改着改着又加回去了.. 我修正一下
zombieJ
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
fix #40282
💡 Background and solution
📝 Changelog
iconPrefixCls时，按钮加载图标动画丢失问题☑️ Self-Check before Merge