This repository has been archived by the owner on Aug 11, 2020. It is now read-only.
Using intl on a few more example pages to help with internationalization #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scouttyg
commented
Jul 14, 2020
scouttyg
commented
Jul 14, 2020
scouttyg
commented
Jul 14, 2020
Codecov Report
@@ Coverage Diff @@
## master #568 +/- ##
=======================================
Coverage 64.96% 64.96%
=======================================
Files 34 34
Lines 1079 1079
Branches 408 408
=======================================
Hits 701 701
Misses 375 375
Partials 3 3 Continue to review full report at Codecov.
|
scouttyg
commented
Jul 14, 2020
Comment on lines
+14
to
+15
| 'app.alert.umi-ui-available': 'umi ui 现已发布，点击右下角 umi 图标即可使用', | ||
| 'app.alert.umi-ui-released': 'umi ui 现已发布，欢迎使用 npm run ui 启动体验。', |
There was a problem hiding this comment.
Added a few of these here so the alerts could be shown in all languages
scouttyg
commented
Jul 14, 2020
| @@ -23,7 +23,7 @@ export default { | |||
| 'app.setting.sidemenu': 'Side Menu Layout', | |||
| 'app.setting.topmenu': 'Top Menu Layout', | |||
| 'app.setting.mixmenu': 'Mix Menu Layout', | |||
| 'app.setting.splitMenus': 'split menus', | |||
| 'app.setting.splitMenus': 'Split Menus', | |||
There was a problem hiding this comment.
Capitalizing this here since it was the only setting not in "Sentence Case"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a bit more localization to the pro layout as it was a bit hard for me