Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #24519 Upload delete icon cannot be navigate via keyboard #24615

Merged
merged 2 commits into from
Jun 1, 2020

Conversation

morenyang
Copy link
Contributor

@morenyang morenyang commented May 31, 2020

[中文版模板 / Chinese template]

close #24519

change the upload file actions implementation, pls review the code first.
I am still checking if there are some style impacts.

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

  • use Button to wrap action icons
  • update opacity control to actions-btn

ezgif-3-f02e72d7b713

ezgif com-gif-maker

Custom icon have been changed to buttons:
image

📝 Changelog

Language Changelog
🇺🇸 English Fix Upload delete icon cannot be navigate via keyboard.
🇨🇳 Chinese 解决 Upload 删除图标键盘无法导航操作的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@morenyang
Copy link
Contributor Author

@afc163 please review the code and check the style

@ant-design-bot
Copy link
Contributor

ant-design-bot commented May 31, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented May 31, 2020

@codecov
Copy link

codecov bot commented May 31, 2020

Codecov Report

Merging #24615 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24615      +/-   ##
==========================================
+ Coverage   99.20%   99.21%   +0.01%     
==========================================
  Files         365      365              
  Lines        7278     7277       -1     
  Branches     2037     1982      -55     
==========================================
  Hits         7220     7220              
+ Misses         58       57       -1     
Impacted Files Coverage Δ
components/upload/UploadList.tsx 100.00% <100.00%> (+0.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 377ad77...3af397b. Read the comment docs.

@afc163 afc163 merged commit 19ca646 into ant-design:master Jun 1, 2020
@zombieJ zombieJ mentioned this pull request Jun 2, 2020
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload control remove file button is not keyboard accessible
3 participants