Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Collapse expandIconPosition="right" not working #30680

Merged
merged 1 commit into from
May 26, 2021

Conversation

hongdeyuan
Copy link
Contributor

@hongdeyuan hongdeyuan commented May 25, 2021

Signed-off-by: dehong dehong@xsky.com

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #30668

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Collapse expandIconPosition="right" not working.
🇨🇳 Chinese 修复 Collapse expandIconPosition="right" 未生效的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Signed-off-by: dehong <dehong@xsky.com>
@github-actions
Copy link
Contributor

github-actions bot commented May 25, 2021

@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #30680 (0c03803) into master (c542aad) will not change coverage.
The diff coverage is n/a.

❗ Current head 0c03803 differs from pull request most recent head 9a02f3d. Consider uploading reports for the commit 9a02f3d to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##            master    #30680   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          397       397           
  Lines         7544      7544           
  Branches      2112      2112           
=========================================
  Hits          7544      7544           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c542aad...9a02f3d. Read the comment docs.

right: @padding-md;
left: auto;
margin: 0 0 0 12px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
margin: 0 0 0 12px;
margin: 0;

@afc163 afc163 changed the title fix the collapse arrow right fix: Collapse expandIconPosition="right" not working May 26, 2021
@afc163 afc163 merged commit 483c1e3 into ant-design:master May 26, 2021
@ruhankhandakar
Copy link

when it'll get released ??

@yoyo837
Copy link
Contributor

yoyo837 commented May 27, 2021

This weekend, probably Sunday or Monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

新版 Collapse 参数配置 expandIconPosition:right失效
4 participants