Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dropdown selected keys #30802

Merged
merged 2 commits into from
Jun 1, 2021
Merged

fix: Dropdown selected keys #30802

merged 2 commits into from
Jun 1, 2021

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jun 1, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

resolve #30786

💡 Background and solution

看起来原本带图标的 Dropdown Item hover 到图标点击无法触发 a 效果,一并修了。有统一 className 后感觉代码量还少了?帮忙确认一下。

📝 Changelog

Language Changelog
🇺🇸 English Fix Dropdown Item with link color style and click icon can also trigger link effect now.
🇨🇳 Chinese 修复 Dropdown 条目包含超链接时的颜色样式,另外现在点击图标也能触发超链接效果。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2021

@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #30802 (6243939) into master (9f0dbf2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #30802   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          397       397           
  Lines         7571      7543   -28     
  Branches      2123      2113   -10     
=========================================
- Hits          7571      7543   -28     
Impacted Files Coverage Δ
components/tree-select/index.tsx 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f0dbf2...6243939. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2021

Size Change: -247 B (0%)

Total Size: 830 kB

Filename Size Change
./dist/antd.compact.min.css 63.9 kB -86 B (0%)
./dist/antd.dark.min.css 65.2 kB -86 B (0%)
./dist/antd.min.css 64.1 kB -75 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd-with-locales.min.js 340 kB 0 B
./dist/antd.min.js 297 kB 0 B

compressed-size-action

@afc163
Copy link
Member

afc163 commented Jun 1, 2021

修复 Dropdown 条目包含超链接的颜色样式以及现在点击图标也能触发超链接效果。

修复 Dropdown 条目包含超链接时的颜色样式,另外现在点击图标也能触发超链接效果。

@zombieJ zombieJ merged commit 023a1e0 into master Jun 1, 2021
@zombieJ zombieJ deleted the fix-dropdown-style branch June 1, 2021 05:34
@zombieJ zombieJ mentioned this pull request Jun 7, 2021
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v4.16.1 Menu的改动,由于改了class name,使下拉中是a标签的都变成@primery-color
2 participants