Enhance Spin component TypeScript definitions and documentation #49036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
👁 Visual Regression Report for PR #49036 Passed ✅
🎊 Congrats! No visual-regression diff found. 
|
afc163
approved these changes
May 23, 2024
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #49036 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 745 745
Lines 12976 12976
Branches 3400 3400
=========================================
Hits 12976 12976 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances the TypeScript definitions for the
Spincomponent by adding detailed comments to each property within theSpinPropsinterface incomponents/spin/index.tsx.SpinPropsinterface now includes detailed comments explaining its purpose and usage. This includes descriptions forprefixCls,className,rootClassName,spinning,style,size,tip,delay,wrapperClassName,indicator,children, andfullscreen.Spincomponent more effectively within their projects.For more details, open the Copilot Workspace session.