Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table): EditableProTable no tonumber keys #2135

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

chenshuai2144
Copy link
Contributor

@chenshuai2144 chenshuai2144 commented Mar 9, 2021

close #2128

@github-actions
Copy link

github-actions bot commented Mar 9, 2021

🎊 PR Preview 093b268 has been successfully built and deployed to https://ant-design-pro-components-preview-pr-2135.surge.sh

🕐 Build time: 577.98s

🤖 By surge-preview

@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #2135 (093b268) into master (5ea2e88) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2135      +/-   ##
==========================================
- Coverage   99.09%   99.09%   -0.01%     
==========================================
  Files         162      162              
  Lines        4844     4840       -4     
  Branches     1747     1745       -2     
==========================================
- Hits         4800     4796       -4     
  Misses         43       43              
  Partials        1        1              
Impacted Files Coverage Δ
...utils/src/components/InlineErrorFormItem/index.tsx 100.00% <ø> (ø)
packages/utils/src/useEditableArray/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ea2e88...093b268. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Mar 9, 2021

size-limit report

Path Size
packages/card/dist/card.js 17.26 KB (0%)
packages/descriptions/dist/descriptions.js 20.49 KB (0%)
packages/field/dist/field.js 132.48 KB (0%)
packages/form/dist/form.js 56.88 KB (0%)
packages/layout/dist/layout.js 76.37 KB (0%)
packages/list/dist/list.js 142.66 KB (0%)
packages/provider/dist/provider.js 10.97 KB (0%)
packages/skeleton/dist/skeleton.js 5.18 KB (0%)
packages/table/dist/table.js 44.84 KB (0%)

@chenshuai2144 chenshuai2144 merged commit b4d3c0a into master Mar 9, 2021
@chenshuai2144 chenshuai2144 deleted the EditableProTable-tonumber branch March 9, 2021 09:01
@blackraindrop
Copy link
Contributor

@chenshuai2144 这样改的话就不支持number了吧。
image

@blackraindrop
Copy link
Contributor

kvMap因为是Map类型,所以里面的键可以是number或者string,可以共存的。{1:50,"1":24}

@chenshuai2144 chenshuai2144 restored the EditableProTable-tonumber branch March 29, 2021 03:35
@chenshuai2144 chenshuai2144 deleted the EditableProTable-tonumber branch March 29, 2021 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants