Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form): render option failed while key is number 0. #4389

Merged
merged 1 commit into from
Dec 31, 2021
Merged

fix(form): render option failed while key is number 0. #4389

merged 1 commit into from
Dec 31, 2021

Conversation

AdoKevin
Copy link
Contributor

fix field select issue that number 0 as option value not render its label while options from request method. BTW, save value as map key to avoid number type convert to string as object key.

@github-actions
Copy link

github-actions bot commented Dec 31, 2021

🎊 PR Preview has been successfully built and deployed to https://pro-components-preview-pr-4389.surge.sh

@codecov
Copy link

codecov bot commented Dec 31, 2021

Codecov Report

Merging #4389 (15c83d1) into master (4a83337) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4389      +/-   ##
==========================================
- Coverage   99.22%   99.22%   -0.01%     
==========================================
  Files         189      189              
  Lines        6343     6342       -1     
  Branches     2245     2242       -3     
==========================================
- Hits         6294     6293       -1     
  Misses         48       48              
  Partials        1        1              
Impacted Files Coverage Δ
packages/field/src/components/Select/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a83337...15c83d1. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants