Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(field): 解决只读模式默认值为空的情况不走render的问题 #630

Merged
merged 9 commits into from
Nov 16, 2020

Conversation

txp1035
Copy link
Contributor

@txp1035 txp1035 commented Sep 29, 2020

值为空也应该走render

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Sep 29, 2020

This pull request introduces 1 alert when merging ed71222 into 2227dba - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@codecov
Copy link

codecov bot commented Sep 29, 2020

Codecov Report

Merging #630 (717fcec) into master (ad72be3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #630   +/-   ##
=======================================
  Coverage   96.13%   96.13%           
=======================================
  Files         141      141           
  Lines        3750     3753    +3     
  Branches     1313     1313           
=======================================
+ Hits         3605     3608    +3     
  Misses        141      141           
  Partials        4        4           
Impacted Files Coverage Δ
packages/field/src/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad72be3...717fcec. Read the comment docs.

@chenshuai2144
Copy link
Contributor

chenshuai2144 commented Sep 30, 2020

标题写一下

fix(组件) :我干了什么

@txp1035 txp1035 changed the title fix: render fix(proField): 解决只读模式默认值为空的情况不走render的问题 Sep 30, 2020
@chenshuai2144 chenshuai2144 changed the title fix(proField): 解决只读模式默认值为空的情况不走render的问题 fix(field): 解决只读模式默认值为空的情况不走render的问题 Sep 30, 2020
@txp1035 txp1035 changed the title fix(field): 解决只读模式默认值为空的情况不走render的问题 [WIP]fix(field): 解决只读模式默认值为空的情况不走render的问题 Sep 30, 2020
@txp1035
Copy link
Contributor Author

txp1035 commented Sep 30, 2020

啥用例也没有写覆盖率还加了0.01 😃

@chenshuai2144
Copy link
Contributor

你加了个demo,触发一些逻辑

@txp1035
Copy link
Contributor Author

txp1035 commented Sep 30, 2020

image
这里不能进行mode配置还是类型漏掉了啊?

@chenshuai2144 chenshuai2144 changed the title [WIP]fix(field): 解决只读模式默认值为空的情况不走render的问题 fix(field): 解决只读模式默认值为空的情况不走render的问题 Nov 16, 2020
@github-actions
Copy link

github-actions bot commented Nov 16, 2020

😭 Deploy PR Preview 717fcec failed. Build logs

🤖 By surge-preview

@chenshuai2144 chenshuai2144 merged commit 3ac7297 into ant-design:master Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants