Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table): Record Creator re-render when props change #8018

Merged

Conversation

bartelemi
Copy link
Contributor

what.

Revert previous change to useMemo() dependencies to allow re-rendering record creator button when button props have changed (not just toggled from false to object).

why.

It has to be possible to re-render this button, in situations, when for example its state changed from "disabled" to "enabled".

references.

Closes #7991

Copy link

github-actions bot commented Dec 26, 2023

😭 Deploy PR Preview failed.

@chenshuai2144 chenshuai2144 merged commit c0187d2 into ant-design:master Dec 27, 2023
7 of 8 checks passed
@bartelemi bartelemi deleted the fix/table/record-creator-props branch December 31, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛[BUG] EditableProTable.recordCreatorProps.disabled can't be changed dynamically
2 participants