fix: setTimeout causes process hangs
#10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AriPerkkio
force-pushed
the
fix/set-timeout-process-hang
branch
from
8feba51
to
6a47001
Compare
antfu
reviewed
Aug 21, 2023
| reject(new Error(`[birpc] timeout on calling "${method}"`)) | ||
| rpcPromiseMap.delete(id) | ||
| }, timeout) | ||
| }, timeout).unref?.() |
There was a problem hiding this comment.
.unref might need to be called conditionally as birpc will also run on browsers.
There was a problem hiding this comment.
setTimeout should always return something in browsers. Isn't condition for unref? enough?
https://developer.mozilla.org/en-US/docs/Web/API/setTimeout#return_value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes process hangs when
birpcis run insidechild_process.unref()thesetTimeoutcalls. Conditionally for browser support.Error's and callrejectfor every single rpc callLinked Issues
Fixes #9
Additional context
Related to vitest-dev/vitest#3925