Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swift 4.1 #259

Merged
merged 8 commits into from
Apr 10, 2018
Merged

Swift 4.1 #259

merged 8 commits into from
Apr 10, 2018

Conversation

NachoSoto
Copy link
Contributor

@NachoSoto NachoSoto commented Jan 19, 2018 •
edited by ikesyo
Loading

I'm using the latest development snapshot from January 18th. This compiles! 🎉

Last updated and tested with: Xcode 9.3 beta 2.

TODO:

@NachoSoto NachoSoto requested a review from ikesyo January 19, 2018 21:29
@NachoSoto
Copy link
Contributor Author

NachoSoto commented Jan 19, 2018 •
edited
Loading

I'm also not really sure why we still need the manual == implementation. I thought we could get that for free?

[edit] Answer: https://twitter.com/dgregor79/status/954476048015478784.

@NachoSoto NachoSoto mentioned this pull request Jan 19, 2018
Merged
11 tasks
bencochran
bencochran reviewed Feb 14, 2018
View reviewed changes
Result/ResultProtocol.swift Outdated
extension Result: Equatable where Value: Equatable, Error: Equatable { }
#else
extension Result where Value: Equatable, Error: Equatable {
/// Returns `true` if `left` and `right` represent different cases, or if they represent the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the end of this comment

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ileitch
Copy link

ileitch commented Apr 4, 2018

Anything I can do to help expedite this? Result is blocking our upgrade to 4.1 as all the Swift 4 changes in master are not released.

@mdiep
Copy link
Contributor

mdiep commented Apr 4, 2018

The current release of Result works with Xcode 9.3 / Swift 4.1. How is this blocking you?

@ileitch
Copy link

ileitch commented Apr 4, 2018

I'm getting this error:

error: The following binaries use incompatible versions of Swift:
/path/to/DerivedData/Org-ffzmalvhznxtrccncwsuvfbyfypt/Build/Products/Debug-iphonesimulator/Bowtie.app/Bowtie
/path/to/DerivedData/Org-ffzmalvhznxtrccncwsuvfbyfypt/Build/Products/Debug-iphonesimulator/Bowtie.app/PlugIns/BowtieUnitTests.xctest/Frameworks/Result.framework/Result

@NachoSoto
Copy link
Contributor Author

FYI I’m out of town for a few weeks so somebody else will need to pick this up from me.

@ileitch
Copy link

ileitch commented Apr 4, 2018

After pointing our Podfile at master the build succeeds.

@ikesyo
Copy link
Member

ikesyo commented Apr 6, 2018

I pick this up.

@ikesyo ikesyo changed the title [WIP] Swift 4.1 Swift 4.1 Apr 6, 2018
ikesyo
ikesyo approved these changes Apr 6, 2018
View reviewed changes
Copy link
Member

@ikesyo ikesyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be good to go now (except for Travis's xcode9.3beta).

@ikesyo ikesyo requested a review from mdiep April 6, 2018 05:01
@mdiep
Copy link
Contributor

mdiep commented Apr 6, 2018

Should we wait for an updated Travis image?

@DivineDominion
Copy link

Over at ReSwift, we added compiler conditions to ship quickly (#if swift(>=4.1) #else #endif). Haven't heard back from Travis when they release the Xcode 9.3 final image.

@mdiep
Copy link
Contributor

mdiep commented Apr 10, 2018

Travis has released the xcode9.3 image, so this just needs to be updated now.

@ikesyo
Copy link
Member

ikesyo commented Apr 10, 2018 •
edited
Loading

Just updated to use the xcode9.3 image.

@ikesyo ikesyo merged commit 0cf556c into master Apr 10, 2018
@ikesyo ikesyo deleted the swift-4-1 branch April 10, 2018 14:59
@NachoSoto
Copy link
Contributor Author

👏🏼

@ikesyo ikesyo mentioned this pull request Apr 26, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bencochran bencochran bencochran left review comments

@mdiep mdiep mdiep approved these changes

@ikesyo ikesyo ikesyo approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@NachoSoto @ileitch @mdiep @ikesyo @DivineDominion @bencochran