test(rusty-sword-knight): acceptance tests #689
Conversation
antoinezanardi
added
the
✅ test
WalkthroughThe recent updates introduce a new configuration for the Cucumber.js testing framework tailored to the "Rusty Sword Knight Role," enhancing test execution management. Additionally, a feature file has been added to detail the Rusty Sword Knight's interactions in a game scenario, enriching gameplay dynamics and enabling new strategic opportunities against werewolves and villagers. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (2)
- .run/Rusty Sword Knight Role.run.xml (1 hunks)
- tests/acceptance/features/game/features/role/rusty-sword-knight.feature (1 hunks)
Additional comments not posted (7)
.run/Rusty Sword Knight Role.run.xml (6)
2-2: LGTM! Configuration name and type are correctly set.The configuration name "Rusty Sword Knight Role" is descriptive, and the type is appropriately set to "cucumber.js".
3-3: LGTM! File path is correctly set.The file path
$PROJECT_DIR$/tests/acceptancepoints to the acceptance tests directory, which is appropriate for this configuration.
4-4: LGTM! Name filter is correctly set.The name filter option is set to an empty string, meaning no specific name filtering is applied, which is acceptable.
5-5: LGTM! Cucumber.js arguments are correctly set.The arguments include a config file (
--config config/cucumber/cucumber.json), parallel execution (--parallel 1), and a tag filter (--tags @rusty-sword-knight-role), which are appropriate for this configuration.
6-6: LGTM! Working directory is correctly set.The working directory is set to
$PROJECT_DIR$, which is appropriate for this configuration.
7-9: LGTM! Environment variable is correctly set.The environment variable
NODE_OPTIONSis set to--import tsx/esm, ensuring the proper import of ES modules.tests/acceptance/features/game/features/role/rusty-sword-knight.feature (1)
1-3: LGTM! Scenario tags and feature name are correctly set.The scenario is tagged with
@rusty-sword-knight-roleand@shard-1, which are appropriate for filtering. The feature name "🤺 Rusty Sword Knight role" is descriptive.
tests/acceptance/features/game/features/role/rusty-sword-knight.feature
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- tests/acceptance/features/game/features/role/rusty-sword-knight.feature (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- tests/acceptance/features/game/features/role/rusty-sword-knight.feature
|
## [1.27.0](v1.26.0...v1.27.0) (2024-08-07) ### 🚀 Features * **bear-tamer:** bear tamer events ([#677](#677)) ([3d890fd](3d890fd)) * **docker:** docker file and push to hub ([#708](#708)) ([3e1a22d](3e1a22d)) * **elder:** elder has taken revenge event ([#656](#656)) ([25f46d5](25f46d5)) * **fox:** game events ([#692](#692)) ([0de3432](0de3432)) * **game-lobby:** additional cards manager ([#706](#706)) ([5eb8ce3](5eb8ce3)) * **game-lobby:** display position coordinator button on two players ([#698](#698)) ([404b184](404b184)) * **game:** game events from api ([#674](#674)) ([cc5938b](cc5938b)) * **scandalmonger:** scandalmonger mark is active event ([#681](#681)) ([828acaa](828acaa)) ### 🐛 Bug Fixes * **deps:** update dependency primevue to v4 ([#605](#605)) ([c05c2be](c05c2be)) ### ✅ Tests * **fox:** targets in game events ([#696](#696)) ([7eb4ff6](7eb4ff6)) * **rusty-sword-knight:** acceptance tests ([#689](#689)) ([8b60d86](8b60d86)) ### 🧹 Chore * **deps:** update antoinezanardi/werewolves-assistant-api docker tag to v1.35.1 ([#720](#720)) ([a4eef03](a4eef03)) * **deps:** update dependency @commitlint/cli to ^19.4.0 ([#721](#721)) ([10ae971](10ae971)) * **deps:** update dependency @nuxt/test-utils to ^3.14.0 ([#684](#684)) ([e842c26](e842c26)) * **deps:** update dependency @nuxtjs/i18n to ^8.3.2 ([#686](#686)) ([a5fc6d6](a5fc6d6)) * **deps:** update dependency @nuxtjs/i18n to ^8.3.3 ([#688](#688)) ([6c04526](6c04526)) * **deps:** update dependency @pinia/nuxt to ^0.5.2 ([#679](#679)) ([268cb94](268cb94)) * **deps:** update dependency @pinia/nuxt to ^0.5.3 ([#712](#712)) ([4c0e823](4c0e823)) * **deps:** update dependency @pinia/testing to ^0.1.4 ([#680](#680)) ([6aaa549](6aaa549)) * **deps:** update dependency @pinia/testing to ^0.1.5 ([#713](#713)) ([1e865de](1e865de)) * **deps:** update dependency @stryker-mutator/core to ^8.4.0 ([#717](#717)) ([18fd997](18fd997)) * **deps:** update dependency @stylistic/eslint-plugin to ^2.4.0 ([#687](#687)) ([b96f302](b96f302)) * **deps:** update dependency @stylistic/eslint-plugin to ^2.6.1 ([#701](#701)) ([d057800](d057800)) * **deps:** update dependency @types/eslint to v9 ([#665](#665)) ([e4cf01c](e4cf01c)) * **deps:** update dependency eslint to ^9.8.0 ([#685](#685)) ([722ad20](722ad20)) * **deps:** update dependency husky to ^9.1.1 ([#650](#650)) ([03ff232](03ff232)) * **deps:** update dependency husky to ^9.1.2 ([#675](#675)) ([8b450f1](8b450f1)) * **deps:** update dependency husky to ^9.1.3 ([#683](#683)) ([8fb79bb](8fb79bb)) * **deps:** update dependency husky to ^9.1.4 ([#690](#690)) ([8e4afd7](8e4afd7)) * **deps:** update dependency lint-staged to ^15.2.8 ([#707](#707)) ([9d0ea50](9d0ea50)) * **deps:** update dependency msw to ^2.3.2 ([#654](#654)) ([df18287](df18287)) * **deps:** update dependency msw to ^2.3.3 ([#667](#667)) ([4e31286](4e31286)) * **deps:** update dependency msw to ^2.3.4 ([#668](#668)) ([d368d3a](d368d3a)) * **deps:** update dependency msw to ^2.3.5 ([#705](#705)) ([e44c938](e44c938)) * **deps:** update dependency pinia to ^2.2.0 ([#682](#682)) ([a264598](a264598)) * **deps:** update dependency pinia to ^2.2.1 ([#714](#714)) ([7ec9618](7ec9618)) * **deps:** update dependency prettier-plugin-gherkin to ^2.4.1 ([#678](#678)) ([fdf456f](fdf456f)) * **deps:** update dependency prettier-plugin-gherkin to v3 ([#693](#693)) ([951b899](951b899)) * **deps:** update dependency qs to ^6.13.0 ([#703](#703)) ([be22e54](be22e54)) * **deps:** update dependency tailwindcss to ^3.4.7 ([#676](#676)) ([9653815](9653815)) * **deps:** update dependency tailwindcss to ^3.4.8 ([#722](#722)) ([706364a](706364a)) * **deps:** update dependency tsx to ^4.16.3 ([#694](#694)) ([ac58a05](ac58a05)) * **deps:** update dependency tsx to ^4.16.5 ([#702](#702)) ([bd33184](bd33184)) * **deps:** update dependency type-fest to ^4.22.1 ([#651](#651)) ([e21922d](e21922d)) * **deps:** update dependency type-fest to ^4.23.0 ([#661](#661)) ([54e81b0](54e81b0)) * **deps:** update dependency typescript to ^5.5.4 ([#666](#666)) ([b3d9999](b3d9999)) * **deps:** update dependency validate-branch-name to ^1.3.1 ([#672](#672)) ([ee73726](ee73726)) * **deps:** update dependency vue to ^3.4.33 ([#655](#655)) ([2b6f4be](2b6f4be)) * **deps:** update dependency vue to ^3.4.34 ([#671](#671)) ([a4628ae](a4628ae)) * **deps:** update dependency vue to ^3.4.35 ([#695](#695)) ([632b6e6](632b6e6)) * **deps:** update dependency vue to ^3.4.36 ([#715](#715)) ([0e26759](0e26759)) * **deps:** update dependency vue-router to ^4.4.2 ([#699](#699)) ([55c7ea4](55c7ea4)) * **deps:** update dependency vue-router to ^4.4.3 ([#716](#716)) ([41940fc](41940fc)) * **deps:** update dependency vue-tsc to ^2.0.28 ([#658](#658)) ([376855f](376855f)) * **deps:** update dependency vue-tsc to ^2.0.29 ([#673](#673)) ([e8c0b73](e8c0b73)) * **deps:** update node docker tag to v22.6.0 ([#718](#718)) ([2b3eb0f](2b3eb0f)) * **deps:** update node.js to >=20.16.0 ([#670](#670)) ([4b03818](4b03818)) * **deps:** update nuxtjs monorepo to ^3.12.4 ([#653](#653)) ([08a94ce](08a94ce)) * **deps:** update playwright monorepo to ^1.45.3 ([#663](#663)) ([99322ea](99322ea)) * **deps:** update playwright monorepo to ^1.46.0 ([#710](#710)) ([cdcc769](cdcc769)) * **deps:** update pnpm to v9.6.0 ([#657](#657)) ([8a18dec](8a18dec)) * **deps:** update pnpm to v9.7.0 ([#719](#719)) ([deb0b81](deb0b81)) * **deps:** update stryker-js monorepo to ^8.3.0 ([#704](#704)) ([0d4788e](0d4788e)) * **deps:** update stryker-js monorepo to ^8.4.0 ([#711](#711)) ([5def08d](5def08d)) * **deps:** update typescript-eslint monorepo to ^7.17.0 ([#664](#664)) ([cf7484f](cf7484f)) * **deps:** update typescript-eslint monorepo to ^7.18.0 ([#691](#691)) ([fe46fff](fe46fff)) * **deps:** update typescript-eslint monorepo to ^8.0.1 ([#709](#709)) ([d189e1e](d189e1e)) * **deps:** update typescript-eslint monorepo to v8 (major) ([#700](#700)) ([de6cf8d](de6cf8d)) * **deps:** update vitest monorepo to ^2.0.3 ([#636](#636)) ([0cdd8e6](0cdd8e6)) * **deps:** update vitest monorepo to ^2.0.4 ([#659](#659)) ([a4a5d77](a4a5d77)) * **deps:** update vitest monorepo to ^2.0.5 ([#697](#697)) ([5783273](5783273))
|
🎉 This PR is included in version 1.27.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary by CodeRabbit
New Features
Configuration Updates