fix(buttons): correct icon slots #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedReview was skipped due to path filters Files ignored due to path filters (49)
You can disable this status message by setting the WalkthroughThe recent changes involve a restructuring of button components across various Vue files to enhance their flexibility and maintainability. By using Vue's slot mechanism for icon rendering and directly binding button labels as props, the updated components promote better practices and facilitate future customizations. These modifications retain the original functionality while improving the overall clarity and organization of the code. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ParentComponent
participant ButtonComponent
participant IconComponent
User->>ParentComponent: Clicks Button
ParentComponent->>ButtonComponent: Handles Click Event
ButtonComponent->>IconComponent: Renders Icon in Slot
ButtonComponent-->>User: Displays Button with Icon and Label
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
app/components/pages/game-lobby/GameLobbyHeader/GameLobbyHeaderSetupButtons/GameLobbyHeaderPositionCoordinatorButton/GameLobbyHeaderPositionCoordinatorButton.vue (1)
4-4: Translation Key Missing in Localization FilesThe translation key
'components.GameLobbyHeaderPositionCoordinatorButton.positionCoordinator'is not defined in the localization files. Please ensure that it is added to the appropriate localization files to support proper localization functionality.
- Verify that the key is added to the relevant JSON or YAML files within your localization directories (
locales,i18n, etc.).Analysis chain
LGTM! Verify the label prop usage.
The direct binding of the label using
$tenhances localization support. Ensure that the translation key'components.GameLobbyHeaderPositionCoordinatorButton.positionCoordinator'is correctly defined in your localization files.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the existence of the translation key for the label prop. # Test: Search for the translation key in localization files. Expect: The key should be defined. rg --type json --type yaml 'components.GameLobbyHeaderPositionCoordinatorButton.positionCoordinator'Length of output: 1225
Script:
#!/bin/bash # Description: Search for the translation key in known localization directories. # Test: Search for the translation key in common localization directories. rg --type json --type yaml 'components.GameLobbyHeaderPositionCoordinatorButton.positionCoordinator' --glob '**/locales/**' --glob '**/i18n/**'Length of output: 143
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (113)
tests/acceptance/screenshots/darwin/About Page.pngis excluded by!**/*.pngtests/acceptance/screenshots/darwin/Accursed Wolf-Father infects Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/darwin/Actor chooses card Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/darwin/Big Bad Wolf eats Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/darwin/Charmed people meet each other Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/darwin/Cupid charms Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/darwin/Defender protects Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/darwin/Fox sniffs Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/darwin/Game Lobby Additional Cards Manager with 5 cards.pngis excluded by!**/*.pngtests/acceptance/screenshots/darwin/Game Lobby Additional Cards Manager without cards.pngis excluded by!**/*.pngtests/acceptance/screenshots/darwin/Game Lobby Options Hub on Composition tab.pngis excluded by!**/*.pngtests/acceptance/screenshots/darwin/Game Lobby Options Hub on Roles tab.pngis excluded by!**/*.pngtests/acceptance/screenshots/darwin/Game Lobby Options Hub on Votes tab.pngis excluded by!**/*.pngtests/acceptance/screenshots/darwin/Game Lobby Page with 40 players.pngis excluded by!**/*.pngtests/acceptance/screenshots/darwin/Game Lobby Page without players.pngis excluded by!**/*.pngtests/acceptance/screenshots/darwin/Game Lobby Role Picker with picked role.pngis excluded by!**/*.pngtests/acceptance/screenshots/darwin/Game Lobby Role Picker without picked role.pngis excluded by!**/*.pngtests/acceptance/screenshots/darwin/Game Phase Event.pngis excluded by!**/*.pngtests/acceptance/screenshots/darwin/Game Playground without targets.pngis excluded by!**/*.pngtests/acceptance/screenshots/darwin/Game Starts Event.pngis excluded by!**/*.pngtests/acceptance/screenshots/darwin/Game canceled.pngis excluded by!**/*.pngtests/acceptance/screenshots/darwin/Game not found.pngis excluded by!**/*.pngtests/acceptance/screenshots/darwin/Game won by Angel.pngis excluded by!**/*.pngtests/acceptance/screenshots/darwin/Game won by Lovers and Cupid.pngis excluded by!**/*.pngtests/acceptance/screenshots/darwin/Game won by Lovers.pngis excluded by!**/*.pngtests/acceptance/screenshots/darwin/Game won by Pied Piper.pngis excluded by!**/*.pngtests/acceptance/screenshots/darwin/Game won by Villagers.pngis excluded by!**/*.pngtests/acceptance/screenshots/darwin/Game won by Werewolves.pngis excluded by!**/*.pngtests/acceptance/screenshots/darwin/Game won by White Werewolf.pngis excluded by!**/*.pngtests/acceptance/screenshots/darwin/Game won by nobody.pngis excluded by!**/*.pngtests/acceptance/screenshots/darwin/Hunter shoots Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/darwin/Lovers meet each other Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/darwin/Pied Piper charms Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/darwin/Scandalmonger marks Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/darwin/Seer looks Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/darwin/Sheriff delegates Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/darwin/Sheriff settles votes Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/darwin/Stuttering Judge Requests Another Vote Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/darwin/Survivors elect Sheriff Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/darwin/Thief chooses card Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/darwin/Three Brothers meet each other Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/darwin/Two Sisters meet each other Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/darwin/Werewolves eat Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/darwin/White Werewolf eats Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/darwin/Wild Child chooses model Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/darwin/Witch out of potions Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/darwin/Witch uses death potion Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/darwin/Witch uses life potion Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/darwin/Wolf-Hound chooses side Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/About Page.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/Accursed Wolf-Father infects Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/Actor chooses card Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/Big Bad Wolf eats Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/Charmed people meet each other Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/Cupid charms Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/Defender protects Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/Fox sniffs Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/Game Lobby Additional Cards Manager with 5 cards.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/Game Lobby Additional Cards Manager without cards.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/Game Lobby Options Hub on Composition tab.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/Game Lobby Options Hub on Roles tab.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/Game Lobby Options Hub on Votes tab.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/Game Lobby Page with 40 players.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/Game Lobby Page without players.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/Game Lobby Role Picker with picked role.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/Game Lobby Role Picker without picked role.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/Game Phase Event.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/Game Playground without targets.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/Game Starts Event.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/Game canceled.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/Game not found.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/Game won by Angel.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/Game won by Lovers and Cupid.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/Game won by Lovers.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/Game won by Pied Piper.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/Game won by Villagers.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/Game won by Werewolves.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/Game won by White Werewolf.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/Game won by nobody.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/Home Page.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/Hunter shoots Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/Lovers meet each other Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/Page not found.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/Pied Piper charms Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/Scandalmonger marks Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/Seer looks Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/Sheriff delegates Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/Sheriff settles votes Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/Stuttering Judge Requests Another Vote Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/Survivors elect Sheriff Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/Thief chooses card Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/Three Brothers meet each other Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/Two Sisters meet each other Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/Werewolves eat Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/White Werewolf eats Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/Wild Child chooses model Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/Witch out of potions Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/Witch uses death potion Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/Witch uses life potion Playground.pngis excluded by!**/*.pngtests/acceptance/screenshots/linux/Wolf-Hound chooses side Playground.pngis excluded by!**/*.pngtests/unit/specs/__snapshots__/app.nuxt.spec.ts.snapis excluded by!**/*.snaptests/unit/specs/components/pages/game-lobby/GameLobbyAdditionalCardsManager/GameLobbyAdditionalCardsManagerContent/RecipientRoleAdditionalCardsManager/RecipientRoleAdditionalCardsMultiSelect/__snapshots__/RecipientRoleAdditionalCardsMultiSelect.nuxt.spec.ts.snapis excluded by!**/*.snaptests/unit/specs/components/pages/game-lobby/GameLobbyFooter/GameLobbyRandomCompositionButton/__snapshots__/GameLobbyRandomCompositionButton.nuxt.spec.ts.snapis excluded by!**/*.snaptests/unit/specs/components/pages/game-lobby/GameLobbyFooter/GameLobbyStartGameButton/GameLobbyStartGameConfirmDialog/GameLobbyStartGameConfirmDialogContainer/GameLobbyStartGameConfirmDialogFooter/__snapshots__/GameLobbyStartGameConfirmDialogFooter.nuxt.spec.ts.snapis excluded by!**/*.snaptests/unit/specs/components/pages/game-lobby/GameLobbyFooter/GameLobbyStartGameButton/__snapshots__/GameLobbyStartGameButton.nuxt.spec.ts.snapis excluded by!**/*.snaptests/unit/specs/components/pages/game-lobby/GameLobbyHeader/GameLobbyHeaderSetupButtons/GameLobbyHeaderAdditionalCardsManagerButton/__snapshots__/GameLobbyHeaderAdditionalCardsManagerButton.nuxt.spec.ts.snapis excluded by!**/*.snaptests/unit/specs/components/pages/game-lobby/GameLobbyHeader/GameLobbyHeaderSetupButtons/GameLobbyHeaderOptionsButton/__snapshots__/GameLobbyHeaderOptionsButton.nuxt.spec.ts.snapis excluded by!**/*.snaptests/unit/specs/components/pages/game-lobby/GameLobbyHeader/GameLobbyHeaderSetupButtons/GameLobbyHeaderPositionCoordinatorButton/__snapshots__/GameLobbyHeaderPositionCoordinatorButton.nuxt.spec.ts.snapis excluded by!**/*.snaptests/unit/specs/components/pages/game-lobby/GameLobbyHeader/GameLobbyPlayerInput/__snapshots__/GameLobbyPlayerInput.nuxt.spec.ts.snapis excluded by!**/*.snaptests/unit/specs/components/pages/game-lobby/GameLobbyPlayersParty/GameLobbyPlayerCard/__snapshots__/GameLobbyPlayerCard.nuxt.spec.ts.snapis excluded by!**/*.snaptests/unit/specs/components/pages/game/GameOver/GameOverActions/GameOverCreateNewGameButton/__snapshots__/GameOverCreateNewGameButton.nuxt.spec.ts.snapis excluded by!**/*.snaptests/unit/specs/components/pages/game/GameOver/GameOverActions/__snapshots__/GameOverActions.nuxt.spec.ts.snapis excluded by!**/*.snaptests/unit/specs/components/pages/game/GamePlaying/GamePlayground/GamePlaygroundFooter/GamePlaygroundFooterMakePlayButton/__snapshots__/GamePlaygroundFooterMakePlayButton.nuxt.spec.ts.snapis excluded by!**/*.snap
Files selected for processing (15)
- app/components/layouts/default/NavBar/ParametersMenu/ParametersMenu.vue (1 hunks)
- app/components/pages/game-lobby/GameLobbyAdditionalCardsManager/GameLobbyAdditionalCardsManagerContent/RecipientRoleAdditionalCardsManager/RecipientRoleAdditionalCardsMultiSelect/RecipientRoleAdditionalCardsMultiSelect.vue (1 hunks)
- app/components/pages/game-lobby/GameLobbyFooter/GameLobbyRandomCompositionButton/GameLobbyRandomCompositionButton.vue (1 hunks)
- app/components/pages/game-lobby/GameLobbyFooter/GameLobbyStartGameButton/GameLobbyStartGameButton.vue (1 hunks)
- app/components/pages/game-lobby/GameLobbyFooter/GameLobbyStartGameButton/GameLobbyStartGameConfirmDialog/GameLobbyStartGameConfirmDialogContainer/GameLobbyStartGameConfirmDialogFooter/GameLobbyStartGameConfirmDialogFooter.vue (1 hunks)
- app/components/pages/game-lobby/GameLobbyHeader/GameLobbyHeaderSetupButtons/GameLobbyHeaderAdditionalCardsManagerButton/GameLobbyHeaderAdditionalCardsManagerButton.vue (1 hunks)
- app/components/pages/game-lobby/GameLobbyHeader/GameLobbyHeaderSetupButtons/GameLobbyHeaderOptionsButton/GameLobbyHeaderOptionsButton.vue (1 hunks)
- app/components/pages/game-lobby/GameLobbyHeader/GameLobbyHeaderSetupButtons/GameLobbyHeaderPositionCoordinatorButton/GameLobbyHeaderPositionCoordinatorButton.vue (1 hunks)
- app/components/pages/game-lobby/GameLobbyHeader/GameLobbyPlayerInput/GameLobbyPlayerInput.vue (1 hunks)
- app/components/pages/game-lobby/GameLobbyPlayersParty/GameLobbyPlayerCard/GameLobbyPlayerCard.vue (1 hunks)
- app/components/pages/game/GameOver/GameOverActions/GameOverActions.vue (1 hunks)
- app/components/pages/game/GameOver/GameOverActions/GameOverCreateNewGameButton/GameOverCreateNewGameButton.vue (1 hunks)
- app/components/pages/game/GamePlaying/GamePlayground/GamePlaygroundFooter/GamePlaygroundFooterMakePlayButton/GamePlaygroundFooterMakePlayButton.vue (1 hunks)
- tests/unit/specs/components/pages/game-lobby/GameLobbyFooter/GameLobbyStartGameButton/GameLobbyStartGameConfirmDialog/GameLobbyStartGameConfirmDialogContainer/GameLobbyStartGameConfirmDialogFooter/GameLobbyStartGameConfirmDialogFooter.nuxt.spec.ts (4 hunks)
- tests/unit/specs/components/pages/game/GameOver/GameOverActions/GameOverCreateNewGameButton/GameOverCreateNewGameButton.nuxt.spec.ts (2 hunks)
Files skipped from review due to trivial changes (3)
- app/components/layouts/default/NavBar/ParametersMenu/ParametersMenu.vue
- app/components/pages/game-lobby/GameLobbyHeader/GameLobbyHeaderSetupButtons/GameLobbyHeaderOptionsButton/GameLobbyHeaderOptionsButton.vue
- app/components/pages/game/GameOver/GameOverActions/GameOverActions.vue
Additional comments not posted (18)
app/components/pages/game-lobby/GameLobbyHeader/GameLobbyHeaderSetupButtons/GameLobbyHeaderPositionCoordinatorButton/GameLobbyHeaderPositionCoordinatorButton.vue (1)
10-15: LGTM! The use of slots for the icon is a good practice.Encapsulating the icon rendering within a slot improves the component's structure and maintainability.
app/components/pages/game-lobby/GameLobbyHeader/GameLobbyHeaderSetupButtons/GameLobbyHeaderAdditionalCardsManagerButton/GameLobbyHeaderAdditionalCardsManagerButton.vue (1)
21-21: LGTM! Verify the condition logic for thebeatproperty.The conditional
beatproperty enhances visual feedback when additional cards are not set. Ensure that the logic forareAdditionalCardsSetForAdditionalCardsDependantRolesis correctly implemented and tested.Verification successful
Verification Successful: Logic for
areAdditionalCardsSetForAdditionalCardsDependantRolesis CorrectThe condition logic for the
beatproperty, which relies onareAdditionalCardsSetForAdditionalCardsDependantRoles, is correctly implemented. The logic ensures that additional cards are set for roles that require them, such as the actor, if present. The tests inuseCreateGameDtoValidation.spec.tsshould adequately cover these scenarios.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the logic for `areAdditionalCardsSetForAdditionalCardsDependantRoles`. # Test: Search for the definition and usage of `areAdditionalCardsSetForAdditionalCardsDependantRoles`. Expect: Correct logic implementation. rg --type ts 'areAdditionalCardsSetForAdditionalCardsDependantRoles'Length of output: 1007
Script:
#!/bin/bash # Extract the implementation details of `areAdditionalCardsSetForAdditionalCardsDependantRoles` and its dependencies. ast-grep --lang typescript --pattern 'const areAdditionalCardsSetForAdditionalCardsDependantRoles = computed<boolean>(() => $_)' app/composables/api/game/useCreateGameDtoValidation.ts ast-grep --lang typescript --pattern 'const areAdditionalCardsSetForActorIfPresent = $_' app/composables/api/game/useCreateGameDtoValidation.tsLength of output: 1503
app/components/pages/game/GameOver/GameOverActions/GameOverCreateNewGameButton/GameOverCreateNewGameButton.vue (2)
33-37: LGTM! The use of slots for icons improves clarity.Utilizing slots for icons enhances the maintainability and clarity of the component's template.
30-30: LGTM! Verify the label prop usage.The introduction of the label prop streamlines the button's text rendering. Ensure that the translation key
'components.GameOverActions.createAnotherGame'is correctly defined in your localization files.app/components/pages/game-lobby/GameLobbyPlayersParty/GameLobbyPlayerCard/GameLobbyPlayerCard.vue (1)
16-21: Good use of slots for icon customization.The implementation of the named slot
#iconfor theFontAwesomeIconwithin thePrimeVueButtonis a good practice. It enhances the flexibility and modularity of the component, allowing for easier customization of the icon without altering the button's core functionality.app/components/pages/game-lobby/GameLobbyFooter/GameLobbyStartGameButton/GameLobbyStartGameConfirmDialog/GameLobbyStartGameConfirmDialogContainer/GameLobbyStartGameConfirmDialogFooter/GameLobbyStartGameConfirmDialogFooter.vue (4)
8-8: Direct label binding improves maintainability.Binding the
labelprop directly to a translation key simplifies text management and enhances localization support. This change improves maintainability by centralizing text definitions.
13-18: Effective use of slots for icon rendering.The use of the
#iconslot for renderingFontAwesomeIconwithin thePrimeVueButtonstreamlines the button's markup and aligns with best practices for Vue component design. This approach enhances the flexibility and readability of the component.
25-25: Direct label binding for confirm button enhances clarity.Binding the
labelprop for the confirm button directly to theconfirmButtonTextcomputed property improves clarity and maintainability. This change ensures that the button text is managed consistently.
30-36: Consistent use of slots for icon customization.The implementation of the
#iconslot for the confirm button maintains consistency with the cancel button, promoting a uniform design pattern across the component. This enhances the component's modularity and flexibility.app/components/pages/game-lobby/GameLobbyFooter/GameLobbyRandomCompositionButton/GameLobbyRandomCompositionButton.vue (2)
9-9: Prop binding for button label enhances configurability.Passing the
buttonLabelas a prop to thePrimeVueButtonimproves the configurability of the component. This change allows for dynamic label updates and aligns with best practices for component design.
17-21: Slot usage for icon rendering improves flexibility.Encapsulating the
FontAwesomeIconwithin a#iconslot enhances the flexibility of the button component. This approach allows for easy customization of the icon, promoting better separation of concerns.app/components/pages/game-lobby/GameLobbyHeader/GameLobbyPlayerInput/GameLobbyPlayerInput.vue (1)
27-33: LGTM!The use of the
:labelprop and the<template #icon>slot enhances maintainability and readability.app/components/pages/game/GamePlaying/GamePlayground/GamePlaygroundFooter/GamePlaygroundFooterMakePlayButton/GamePlaygroundFooterMakePlayButton.vue (1)
11-22: LGTM!The use of the
:labelprop and the<template #icon>slot enhances maintainability and readability.app/components/pages/game-lobby/GameLobbyFooter/GameLobbyStartGameButton/GameLobbyStartGameButton.vue (1)
11-22: LGTM!The use of the
:labelprop and the<template #icon>slot enhances maintainability and readability.tests/unit/specs/components/pages/game/GameOver/GameOverActions/GameOverCreateNewGameButton/GameOverCreateNewGameButton.nuxt.spec.ts (1)
65-68: Good practice: Testing component props.The test now correctly verifies the
labelprop of the button component, aligning with best practices for Vue component testing.app/components/pages/game-lobby/GameLobbyAdditionalCardsManager/GameLobbyAdditionalCardsManagerContent/RecipientRoleAdditionalCardsManager/RecipientRoleAdditionalCardsMultiSelect/RecipientRoleAdditionalCardsMultiSelect.vue (1)
54-56: Improvement: Use of named slots for icons.The use of the
#iconslot for the button icon enhances the component's flexibility and maintainability.tests/unit/specs/components/pages/game-lobby/GameLobbyFooter/GameLobbyStartGameButton/GameLobbyStartGameConfirmDialog/GameLobbyStartGameConfirmDialogContainer/GameLobbyStartGameConfirmDialogFooter/GameLobbyStartGameConfirmDialogFooter.nuxt.spec.ts (2)
44-47: Good practice: Testing button props.The test now correctly verifies the
labelprop of the cancel button component, ensuring alignment with Vue component testing best practices.
78-81: Good practice: Testing confirm button props.The test cases correctly verify the
labelprop of the confirm button component for different states, enhancing test robustness.Also applies to: 129-132
|
antoinezanardi
pushed a commit
that referenced
this pull request
Aug 20, 2024
## [1.29.0](v1.28.0...v1.29.0) (2024-08-20) ### 🚀 Features * **actor:** actor playground and events ([#747](#747)) ([6c9a034](6c9a034)) * **game-lobby:** thief and actor cards confirm steps ([#760](#760)) ([11a9bd5](11a9bd5)) ### 🐛 Bug Fixes * **buttons:** correct icon slots ([#759](#759)) ([3bfbab9](3bfbab9)) * **docker:** correct docker composes for prod and preprod ([#768](#768)) ([89175cd](89175cd)) ### 📖 Docs * **docker:** explain dockers tags created ([#767](#767)) ([334cc80](334cc80)) ### 🔁 CI * **docker:** push multiple prebuilt images ([32838b1](32838b1)) ### 🧹 Chore * **deps:** update dependency @eslint/config-inspector to ^0.5.3 ([#750](#750)) ([d99ea7c](d99ea7c)) * **deps:** update dependency @eslint/config-inspector to ^0.5.4 ([#761](#761)) ([0196025](0196025)) * **deps:** update dependency @nuxtjs/i18n to ^8.4.0 ([#753](#753)) ([84a86f8](84a86f8)) * **deps:** update dependency @stylistic/eslint-plugin to ^2.6.4 ([#751](#751)) ([8899923](8899923)) * **deps:** update dependency @vueuse/core to ^11.0.1 ([#762](#762)) ([be4784d](be4784d)) * **deps:** update dependency @vueuse/core to v11 ([#754](#754)) ([b1c25df](b1c25df)) * **deps:** update dependency @vueuse/nuxt to ^11.0.1 ([#763](#763)) ([c66613f](c66613f)) * **deps:** update dependency @vueuse/nuxt to v11 ([#755](#755)) ([b3abc86](b3abc86)) * **deps:** update dependency pinia to ^2.2.2 ([#752](#752)) ([96d7032](96d7032)) * **deps:** update dependency semantic-release to ^24.1.0 ([#758](#758)) ([b109f4f](b109f4f)) * **deps:** update dependency type-fest to ^4.25.0 ([#757](#757)) ([c64b715](c64b715)) * **deps:** update dependency vue to ^3.4.38 ([#749](#749)) ([9ceb602](9ceb602)) * **deps:** update playwright monorepo to ^1.46.1 ([#756](#756)) ([df3bf86](df3bf86)) * **deps:** update pnpm to v9.7.1 ([#746](#746)) ([6803a0d](6803a0d)) * **deps:** update typescript-eslint monorepo to ^8.2.0 ([#766](#766)) ([211953e](211953e))
|
🎉 This PR is included in version 1.29.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Bug Fixes
Tests