chore: fix review

antvis · Apr 26, 2020 · ce740a7 · ce740a7
1 parent e13db3a
commit ce740a7
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/docs/manual/tutorial/slider.en.md b/docs/manual/tutorial/slider.en.md
@@ -96,7 +96,7 @@ export interface SliderOption {
   readonly start?: number;
   readonly end?: number;
   /** 滑块文本格式化函数 */
-  readonly formatter?: (options: {val: any, datum: Datum, idx: number}) => string;
+  readonly formatter?: (val: any, datum: Datum, idx: number) => any;
 }
 ```
 

diff --git a/docs/manual/tutorial/slider.zh.md b/docs/manual/tutorial/slider.zh.md
@@ -96,7 +96,7 @@ export interface SliderOption {
   readonly start?: number;
   readonly end?: number;
   /** 滑块文本格式化函数 */
-  readonly formatter?: (options: {val: any, datum: Datum, idx: number}) => string;
+  readonly formatter?: (val: any, datum: Datum, idx: number) => any;
 }
 ```
 

diff --git a/src/chart/controller/slider.ts b/src/chart/controller/slider.ts
@@ -8,7 +8,7 @@ import { isBetween, omit } from '../../util/helper';
 import View from '../view';
 import { Controller } from './base';
 
-export type SliderFormatterType = (options: {val: any, datum: Datum, idx: number}) => string;
+export type SliderFormatterType = (val: any, datum: Datum, idx: number) => any;
 /** Slider 配置 */
 export interface SliderOption {
   /** slider 高度 */
@@ -231,8 +231,8 @@ export default class Slider extends Controller<Option> {
 
     const formatter = this.getSliderCfg().formatter as SliderFormatterType;
     if (formatter) {
-      minText = formatter({ val: minText, datum: data[minIndex], idx: minIndex });
-      maxText = formatter({ val: maxText, datum: data[maxIndex], idx: maxIndex });
+      minText = formatter(minText, data[minIndex], minIndex);
+      maxText = formatter(maxText, data[maxIndex], maxIndex);
     }
 
     // 更新文本