server: Support opening on an existing socket fd #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
any1
reviewed
Jun 1, 2024
There was a problem hiding this comment.
LGTM. Can you squash and force push?
I do wonder if the function should be called nvnc_listen_on_fd or something like that instead of nvnc_open_socket_fd. Other suggestions would be nvnc_open_from_fd or nvnc_create_with_fd. Feel free to pick any of these names or keep it as is.
Add a `struct nvnc* nvnc_open_from_fd(int fd)` function which takes an existing connection-based socket file descriptor bound by the library user or a parent process and just calls listen() on it, as an alternative to letting neatvnc handle socket configuration.
|
Force-pushed with a new commit calling it |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with a systemd .socket unit in any1/wayvnc#310
Supersedes: #69
Required by: any1/wayvnc#227, any1/wayvnc#310
I have read and understood CONTRIBUTING.md.