GO-2973 Add FilterIn

[fat-fellow]

---

• I understand that contributing to this repository will require me to agree with the CLA

---

Description

What type of PR is this? (check all applicable)

• 🍕 Feature
• 🐛 Bug Fix
• 📝 Documentation Update
• 🎨 Style
• 🧑‍💻 Code Refactor
• 🔥 Performance Improvements
• ✅ Test
• 🤖 Build
• 🔁 CI

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

• 👍 yes
• 🙅 no, because they aren't needed
• 🙋 no, because I need help

Added to documentation?

• 📜 README.md
• 📓 tech-docs
• 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[coderabbitai]

Walkthrough

The recent updates enhance the getSpaceIDFromFilter function in the queries.go file by introducing handling for the FilterIn scenario. This ensures that when the filter's key is bundle.RelationKeySpaceId.String(), the function can properly extract and return the first string value. Corresponding tests in queries_test.go were expanded to include this new case, ensuring robustness and correct functionality.

Changes

File Path	Change Summary
pkg/lib/localstore/objectstore/queries.go	Added a case for database.FilterIn in the getSpaceIDFromFilter function to handle bundle.RelationKeySpaceId.String() and return the first string value.
pkg/lib/localstore/objectstore/queries_test.go	Expanded the TestGetSpaceIDFromFilters function to include a new test case for FilterIn type filters with spaceId, verifying the extraction mechanism.

Sequence Diagram(s)

sequenceDiagram
    participant Tester
    participant Queries
    participant Database
    
    Tester->>Queries: TestGetSpaceIDFromFilters
    Queries->>Database: Database query with FilterIn type
    Database-->>Queries: Returns filter data
    Queries-->>Tester: Returns spaceID from filter data

Loading

Poem

🐰 In the world of code, a change is made,
To FilterIn, the function's aid.
Space ID now it duly finds,
With tests expanded, peace of minds.
Hopping along, the filters sing,
CodeRabbit brings joy to everything. 🌟✨

---

Tip

Early access features: enabled

We are currently testing the following features in early access:

• OpenAI gpt-4o model for code reviews and chat: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available.

Note:

• You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
• Please join our Discord Community to provide feedback and report issues.
• OSS projects are currently opted into early access features by default.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Outside diff range and nitpick comments (1)

pkg/lib/localstore/objectstore/queries.go (1)

Line range hint 39-39: Specify keys in the FilterAllIn struct literal.

The FilterAllIn struct literal uses unkeyed fields, which can lead to maintenance issues.

-  optionFilter := database.FilterAllIn{relationKey, listValue.GetListValue()}
+  optionFilter := database.FilterAllIn{Key: relationKey, Value: listValue.GetListValue()}

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 60a1e0f and fc044f5.

Files selected for processing (2)

• pkg/lib/localstore/objectstore/queries.go (1 hunks)
• pkg/lib/localstore/objectstore/queries_test.go (1 hunks)

Additional context used

golangci-lint

pkg/lib/localstore/objectstore/queries.go

[error] 39-39: composites: github.com/anyproto/anytype-heart/pkg/lib/database.FilterAllIn struct literal uses unkeyed fields

(govet)

Additional comments not posted (2)

pkg/lib/localstore/objectstore/queries.go (1)

405-411: LGTM!

The addition of the FilterIn case to handle bundle.RelationKeySpaceId.String() is logical and correct.

pkg/lib/localstore/objectstore/queries_test.go (1)

1096-1105: LGTM!

The addition of the test case for FilterIn to verify the correct extraction of spaceId is logical and correct.

[github-actions]

New Coverage	46.5% of statements
Patch Coverage	100.0% of changed statements (4/4)

---

^{Coverage provided by https://github.com/seriousben/go-patch-cover-action}