Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an NFT create example #173

Merged
merged 2 commits into from
Nov 28, 2022
Merged

Add an NFT create example #173

merged 2 commits into from
Nov 28, 2022

Conversation

mcintyre94
Copy link
Collaborator

This is an example where we use transaction requests to airdrop a freshly created NFT to the buyer as part of the transaction.

See new readme for details of the new example: https://github.com/solana-labs/solana-pay/tree/nft-example/examples/nft-create#readme

  • Moved point-of-sale into a new examples/ directory
  • Add new nft-create example

@vercel
Copy link

vercel bot commented Nov 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
solana-pay ❌ Failed (Inspect) Nov 28, 2022 at 0:21AM (UTC)
solana-pay-docs ✅ Ready (Inspect) Visit Preview Nov 28, 2022 at 0:21AM (UTC)

@socket-security
Copy link

Socket Security Pull Request Report

Dependency issues detected. If you merge this pull request, you will not be alerted to the instances of these issues again.

😵‍💫 Bin script confusion

This package has multiple bin scripts with the same name. This can cause non-deterministic behavior when installing or could be a sign of a supply chain attack

Consider removing one of the conflicting packages. Packages should only export bin scripts with their name

Package Bin script Source
@react-native-community/cli@9.2.1 (added) react-native examples/nft-create/package.json via @solana/wallet-adapter-react@0.15.21-rc.9, @solana-mobile/wallet-adapter-mobile@0.9.7, @react-native-async-storage/async-storage@1.17.10, react-native@0.70.4
react-native@0.70.4 (added) react-native examples/nft-create/package.json via @solana/wallet-adapter-react@0.15.21-rc.9, @solana-mobile/wallet-adapter-mobile@0.9.7, @react-native-async-storage/async-storage@1.17.10
Pull request report summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script confusion ⚠️ 2 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@2.4.2

  • @SocketSecurity ignore @react-native-community/cli@9.2.1
  • @SocketSecurity ignore react-native@0.70.4

⚠️ Please accept the latest app permissions to ensure bot commands work properly. Accept the new permissions here.

Powered by socket.dev

Copy link
Collaborator

@jordaaash jordaaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcintyre94 mcintyre94 merged commit 6091e25 into master Nov 28, 2022
@mcintyre94 mcintyre94 deleted the nft-example branch November 28, 2022 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants