Read the amount from the URL if it is set #203
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
examples/point-of-sale/src/client/components/contexts/PaymentProvider.tsx
Outdated
Show resolved
Hide resolved
| if (Array.isArray(queryAmount)) return new BigNumber(queryAmount[0]); | ||
| return new BigNumber(queryAmount) |
There was a problem hiding this comment.
Hmm, I think we might need to validate the amount in some way. If it doesn't pass a simple regex, we probably don't want to instantiate a BigNumber from it.
There was a problem hiding this comment.
I've added some validation (not NaN, finite, >0) using BigNumber functions. I think that's a bit more straightforward than adding our own regex, and since the amount is displayed on screen + in the wallet it's ok to allow whatever parsing flexibility BigNumber has here. Can add a regex instead if you'd prefer though, I don't have a strong view either way really.
There was a problem hiding this comment.
Yeah, I think either is fine. My idea was simply to check it against ^\d+(\.\d+)?$ since this is (more or less) what describes a valid manual amount entry into the UI. Zero amounts are technically probably okay to allow (they are allowed in the protocol) but I don't care enough to change this.
mcintyre94
force-pushed
the
cm-url-amount
branch
from
71a2fd3
to
106d85c
Compare
mcintyre94
force-pushed
the
cm-url-amount
branch
from
106d85c
to
2caf489
Compare
Closes #202
This issue is caused by the POS app using only local state for the
amount, while other fields (like recipient and label) use the URL values. This PR sets the initial value of theamountstate using theamountquery param if it is present.